libzip-config: Fix variable substitutions #497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When @variables@ are not set during configuration, the resulting substition is 'set(VARIABLE )'. This unsets the variable in the current scope, make visible values from the parent scope. What is needed is setting variables to an empty value in the current scope.
|
(Noticed while updating the vcpkg port.) |
|
Good catch, applied. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
@variables@are not set, or set to an empty value, during configuration, the resulting substition is 'set(VARIABLE )'. This unsets the variable in the current scope when the config is used, make visible values from the parent scope. What is needed is setting variables to an empty value in the current scope. This is achieved by adding quotes.