Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow Node 12 and Node 10.15.2 for Azure #4769

Merged
merged 5 commits into from
Jul 23, 2019
Merged

feat: Allow Node 12 and Node 10.15.2 for Azure #4769

merged 5 commits into from
Jul 23, 2019

Conversation

PieterGit
Copy link
Contributor

  • Allow Node 10.15.2 for Azure instead of ^10.16.0
  • Allow Node 12

This should fix @Pogman report at https://gitter.im/nightscout/public?at=5d34d613ec5abe7bbc2519c0

@Pogman can you confirm that this works for Azure?

@PieterGit PieterGit requested a review from sulkaharo July 21, 2019 23:55
sulkaharo
sulkaharo approved these changes Jul 23, 2019
View reviewed changes
Copy link
Member

@sulkaharo sulkaharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging

@sulkaharo sulkaharo merged commit c9b7e5c into nightscout:dev Jul 23, 2019
@PieterGit PieterGit mentioned this pull request Jul 24, 2019
Closed
@PieterGit PieterGit deleted the 201907_dev branch September 3, 2020 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sulkaharo sulkaharo sulkaharo approved these changes

Assignees
No one assigned
Labels
hosting-azure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PieterGit @sulkaharo