Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependencies #4129

Closed
wants to merge 1 commit into from
Closed

Remove unused dependencies #4129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Scanned the sources with depcheck after recent changes and found we… 
… had were importing `ajv, `long`, `swagger-ui-dist` and `uuid` even though those now have no usages. Tested all base functionality without the modules in place and things seem to work as expected. Additionaly removing old bundle script related to browserify
  • Loading branch information
@sulkaharo
sulkaharo committed Dec 9, 2018
commit f069dd3b0cda00efebba9f51fe6e4d058b8fe77f
17 changes: 0 additions & 17 deletions bundle/index.js
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions lib/server/bootevent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,7 @@ function boot (env, language) {
});

ctx.bus.on('data-loaded', function updatePlugins ( ) {
console.info('reloading sandbox data');
var sbx = require('../sandbox')().serverInit(env, ctx);
ctx.plugins.setProperties(sbx);
ctx.notifications.initRequests();
Expand Down
45 changes: 20 additions & 25 deletions npm-shrinkwrap.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 1 addition & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@
"npm": "6.x"
},
"dependencies": {
"ajv": "^6.5.5",
"async": "^0.9.2",
"body-parser": "^1.18.3",
"bootevent": "0.0.1",
Expand All @@ -74,7 +73,6 @@
"js-storage": "^1.0.4",
"jsonwebtoken": "^8.4.0",
"lodash": "^4.17.11",
"long": "^4.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was required for lib/server/mqtt.js. Can be removed now

"mime": "^2.4.0",
"minimed-connect-to-nightscout": "^1.1.1",
"moment": "^2.22.2",
Expand All @@ -91,10 +89,8 @@
"shiro-trie": "^0.4.8",
"simple-statistics": "^0.7.0",
"socket.io": "^2.1.1",
"swagger-ui-dist": "^3.20.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swagger-ui-dist is needed for /api-docs.html

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see https://github.com/nightscout/cgm-remote-monitor/blob/dev/static/api-docs.html and https://github.com/nightscout/cgm-remote-monitor/search?q=swagger-ui-dist&unscoped_q=swagger-ui-dist

"traverse": "^0.6.6",
"uglify-js": "^3.4.9",
"uuid": "^3.2.1"
"uglify-js": "^3.4.9"
},
"devDependencies": {
"benv": "^3.3.0",
Expand Down