Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MM Connect plugin use devicestatus collection #1460

Merged

Conversation

mddub
Copy link
Contributor

@mddub mddub commented Jan 7, 2016

This brings in the changes from mddub/minimed-connect-to-nightscout#1 and inserts to devicestatus instead of entries.

@codecov-io
Copy link

Current coverage is 75.29%

Merging #1460 into dev will decrease coverage by -0.10% as of a0f119d

@@              dev   #1460   diff @@
=====================================
  Files          93      93       
  Stmts        7621    7622     +1
  Branches        0       0       
  Methods         0       0       
=====================================
- Hit          5746    5739     -7
  Partial         0       0       
- Missed       1875    1883     +8

Review entire Coverage Diff as of a0f119d


Uncovered Suggestions

  1. +0.32% via .../client/boluscalc.js#158...181
  2. +0.26% via .../client/boluscalc.js#301...320
  3. +0.24% via ...lugins/insulinage.js#73...90
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@jasoncalabrese
Copy link
Member

looks going, going to merge

jasoncalabrese added a commit that referenced this pull request Jan 7, 2016
Make MM Connect plugin use devicestatus collection
@jasoncalabrese jasoncalabrese merged commit 2d0c2a4 into nightscout:dev Jan 7, 2016
@mddub mddub deleted the wip/mmconnect-use-devicestatus branch January 8, 2016 00:12
@jasoncalabrese jasoncalabrese added this to the 0.9 milestone Jan 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants