Remove profile toggle and always show Profile Editor link (#4448)

* Remove Profile Editor toggle

`profile` isn't an optional plugin anymore; doesn't need this display toggle. (Plus it was erroneously toggling off in the absence of the `basal` plugin — see #4442.)

* Remove profilecontrol class

lib/client/index.js

@@ -1077,8 +1077,6 @@ client.load = function load(serverSettings, callback) {
   $('.foodcontrol').toggle(client.settings.enable.indexOf('food') > -1);
   // hide cob control if not enabled
   $('.cobcontrol').toggle(client.settings.enable.indexOf('cob') > -1);
-  // hide profile controls if not enabled
-  $('.profilecontrol').toggle(client.settings.enable.indexOf('profile') > -1);
   container.toggleClass('has-minor-pills', client.plugins.hasShownType('pill-minor', client.settings));
 
   function prepareEntries ( ) {

views/index.html

@@ -167,7 +167,7 @@
             <form id="settings-form" role="form" >
                 <ul class="navigation" role="navigation" aria-label="Settings">
                   <li><a href="report" target="reports" class="translate">Reports</a></li>
-                  <li class="profilecontrol"><a id="editprofilelink" href="profile" target="profileeditor" class="translate">Profile Editor</a></li>
+                  <li><a id="editprofilelink" href="profile" target="profileeditor" class="translate">Profile Editor</a></li>
                   <li class="foodcontrol"><a id="editfoodlink" href="food" target="foodeditor" class="translate">Food Editor</a></li>
                   <li><a id="admintoolslink" href="admin" target="admintools" class="translate">Admin Tools</a></li>
                   <li class="multilink">