Release/0.2.8: Fix an error in accounting for insulin with a pod fault during a bolus

[marionbarker]

Purpose:

This fix will be applied to main (with associated increment in version number) and to dev.

Fix the case where a pod fault is treated as an unacknowledged command during an interrupted bolus and the undelivered insulin is subtracted twice from the original bolus amount.

This was reported for both Trio and Loop (the two apps use a common set of OmniBLE and OmniKit modules):

• Trio in Issue 627
• Loop in Issue 2232

Method

The OmniXXX repositories were updated and the code modification tested as reported in these comments:

• Fixes to handle unacknowledged command with pod faults correctly LoopKit/OmniBLE#144 (review)
• Fixes to handle unacknowledged command with pod faults correctly LoopKit/OmniBLE#144 (comment)

See the two PR for OmniXXX:

• Fixes to handle unacknowledged command with pod faults correctly LoopKit/OmniBLE#144
• Fixes to handle unacknowledged command with pod faults correctly LoopKit/OmniKit#52

[bjornoleh]

Approving as one of three required approvals based on Marion’s review to help getting this released. No testing or code review on my part.

[MikePlante1]

All tests done with in-vivo iPhone SE (2020), Glucose Simulator, and Eros pods filled with water.

Here is the zipped Trio folder with logs after all 3 tests were completed:
PR-0.2.8-logs.zip

First, I tested with main 0.2.7 to try to reproduce Issue #627

• Deleted Trio from in-vivo phone and installed Trio-main 0.2.7
• I filled an Eros with ~60U and added to Trio
• Got a 0.3 U SMB
• Manually delivered a 30 U bolus
• Trio set a ZT
• Manually delivered a 28 U bolus
• Trio said 2 U remaining in pod
• ZT was set
• Manually delivered a 12 U bolus
• A third into the bolus the pod screamed
• Error popped up due to empty pod and Cancel Bolus Button disappeared
• Trio still showed the 12 U bolus on main screen and in History
• Tapped the Pod in Trio and deactivated it
• Trio showed 4.75 U Bolus on main screen and in History
  ❌ Not reproduced
  Pump Manager Details: first-pre-PR-test.txt

screenshots

Second, I tried to reproduce it again but this time hit cancel and made sure there was not a ZT set

✅ Negative bolus reproduced

ScreenRecording_07-04-2025.16-00-05_1.MP4

Third, I installed this PR and repeated the second test

✅ Bolus adjusted to actual amount delivered, no negative bolus logged
Pump Manager Details: post-PR-test.txt

ScreenRecording_07-04-2025.22-50-55_1.MP4

[MikePlante1]

Approving based on my test, as well as @itsmojo's edge tests for the submodule

[Sjoerd-Bo3]

LGTM