Skip to content

update G7SensorKit: scan-fix modification #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025
Merged

update G7SensorKit: scan-fix modification #477

merged 1 commit into from
Mar 31, 2025

Conversation

marionbarker
Copy link
Contributor

Use @motinis proposed scan-fix branch for G7SensorKit

  • This improves performance in which G7 sensor readings have not been appearing in the main Trio screen for use in looping
  • There can still be issues, but this reduces the number

Because this PR used the current trio branch for the loopandlearn G7SensorKit repository, it also brings in modifications to the pxbproj file that will later be required to modify the build order for the app. That commit has no effect in how the code performs.

@dnzxy dnzxy merged commit bdc4371 into dev Mar 31, 2025
2 checks passed
@motinis
Copy link

motinis commented Mar 31, 2025

Note that Pete brought a different fix - I think it is working better, although you must start scanning explicitly for a new sensor yourself. There is still work-in-progress there, but for your consideration. LoopKit/G7SensorKit#34

@marionbarker
Copy link
Contributor Author

Additional changes and logging were added to that proposed change. I would let the testing on Loop continue before suggesting changes on Trio.

@dnzxy
Copy link
Contributor

dnzxy commented Mar 31, 2025

Note that Pete brought a different fix - I think it is working better, although you must start scanning explicitly for a new sensor yourself. There is still work-in-progress there, but for your consideration. LoopKit/G7SensorKit#34

For as long as Pete cannot properly explain what the changed condition is attempting to do or fix, we'll go with this attempted fix solution.

@dnzxy dnzxy deleted the g7-scan-fix branch April 22, 2025 21:49
dnzxy pushed a commit that referenced this pull request May 17, 2025
Improve Onboarding Notification Permission Handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants