Skip to content

upgrade looping animation and remove localization for looping text - #1251

Draft
EJM0 wants to merge 25 commits into
nightscout:feat/home-refactorfrom
EJM0:feat/update-loop-indicator
Draft

upgrade looping animation and remove localization for looping text#1251
EJM0 wants to merge 25 commits into
nightscout:feat/home-refactorfrom
EJM0:feat/update-loop-indicator

Conversation

@EJM0

@EJM0 EJM0 commented Jun 29, 2026

Copy link
Copy Markdown

This updates the looping indicator form using the default progress spinner, to being the progress spinner.
Also it disables the localisation for the looping text if loop is active ... see comment.

spinner in action 1. longer loop 4s , 2. shorter loop 1s

ScreenRecording_07-01-2026.13-49-07_1.mov

@EJM0
EJM0 marked this pull request as draft June 30, 2026 19:48
@EJM0
EJM0 marked this pull request as ready for review July 1, 2026 11:51
@iampickle
iampickle force-pushed the feat/update-loop-indicator branch from adc3193 to 6fe44a6 Compare July 1, 2026 15:29
@t1dude

t1dude commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

I’m not sure I agree on the translation block for «looping».

Animation is cool 😎

@EJM0

EJM0 commented Jul 1, 2026

Copy link
Copy Markdown
Author

sadly without locking "looping" the updatePerimeter is a bit messedup and on resizing, the spinner stutters a bit and provokes lagging.

emulated 1s loop

ScreenRecording_07-01-2026.23-42-21_1.mov

P.S. I think I misunderstood. 😅
I reckon blocking localisation could be a good way to tidy up the UI for languages with longer words. Or, we could use looping in the translation as a helpful shortener for languages that might otherwise have translations that are too big.

@dnzxy

dnzxy commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Moving this to draft. Will wire this in when #1332 lands in feat/home-refactor.

@dnzxy
dnzxy marked this pull request as draft July 26, 2026 16:42
@dnzxy
dnzxy changed the base branch from dev to feat/home-refactor July 26, 2026 16:42
@bjornoleh

Copy link
Copy Markdown
Contributor

So there's still time to argue a bit more about the no -localisation of "Looping" 😂

Do we need any wording there at all, with the thing looping around as an animation? Most other strings like this are being replaced with symbols anyways?

@dnzxy

dnzxy commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Most other strings like this are being replaced with symbols anyways?

Huh?

@bjornoleh

Copy link
Copy Markdown
Contributor

We used to have IOB and COB spelled out, and I think some other strings are being done away with in the upcoming refactored UI, such as "i" replacing "i Info".

@EJM0

EJM0 commented Jul 27, 2026

Copy link
Copy Markdown
Author

so sould i change the code to skip the displacement of the looping text, and instead just show the animation of the border and the icon? @bjornoleh

@EJM0

EJM0 commented Jul 27, 2026

Copy link
Copy Markdown
Author

Also a thing to overlook is the display of manual mode, quite nicely translated to "Handbuch“ ( Handbook) in German. I’d suggest only changing the colour/ icon and displaying the remaining time, how long the manual basal rate is scheduled for.

example
image

@bjornoleh

bjornoleh commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

@EJM0 , this isn't up to me, but I suspect that some understandable icons or symbols could potentially do a better job indeed.

Cute German translation of manual mode! It nicely shows how little gamification is needed to make people spend their time to speedrun translations by only clicking on the first auto-translate suggestion without thinking. And Crowdin has very little in the way of gamification in their design 😂

@bjornoleh

Copy link
Copy Markdown
Contributor

But first of all, we shouldn't have to duplicate the info about manual basal both in the pump info and in the loop status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants