Skip to content

Conversation

@swissalpine
Copy link
Contributor

…disconnected

Unfortunately, it is currently no longer possible to set a TempTarget when the pump is disconnected or suspended (TBR: 0%). This seems logical at first sight (why a TempTarget when the pump is not connected or the loop suspended!), but prevents many useful possibilities, namely when the TempTarget should be set immediately after the disconnection or suspension has expired.
An example of this are f. e. sport activities: To reduce IOB, I set a 0% TBR half an hour before sport for one hour with the function "pump disconnected", so that the associated 0% TBR continues for a while while sport starts. I also set a three hour Activity TempTarget. This continues to be active when the pump loops again with the pump disconnected time expired.
The fix allows/reenables setting a TempTarget even if the pump is suspended or disconnected.

…disconnected

Unfortunately, it is currently no longer possible to set a TempTarget when the pump is disconnected or suspended (TBR: 0%). This seems logical at first sight (why a TempTarget when the pump is not connected or the loop suspended!), but prevents many useful possibilities, namely when the TempTarget should be set immediately after the disconnection or suspension has expired.
An example of this are f. e. sport activities: To reduce IOB, I set a 0% TBR half an hour before sport for one hour with the function "pump disconnected", so that the associated 0% TBR continues for a while while sport starts. I also set a three hour Activity TempTarget. This continues to be active when the pump loops again with the pump disconnected time expired.
The fix allows/reenables setting a TempTarget even if the pump is suspended or disconnected.
@MilosKozak
Copy link
Contributor

MilosKozak commented Dec 6, 2021

well I think your problem is a result of misusing "Pump disconnection" feature.
I'm still fan of keeping it as it is now because you have more options to resolve your issue (for example set TT before TBR 0% or instead of disconnection set very low profile) @AdrianLxM

@AdrianLxM
Copy link
Contributor

TT also have the functionality to prevent SMB.
So setting them while disconnected would be a good feature for a scenario like a shower after sports. There you might want to not have them for say one or two hours... But afterwards enable them again automatically.

Enabling TT while disconnected would be straight forward imho. Adding something like temporary preferences to disable SMB for an hour after sports seems overkill for something we could solve with TT.

But maybe there are other solutions?

@AdrianLxM
Copy link
Contributor

An addition to "set very low profile": Wouldn't that cause other issues like if you run away from your phone or it runs out of battery? The pump would have the low profile run for a much longer time than it should?

Copy link
Contributor

@AdrianLxM AdrianLxM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I like it
👍

@MilosKozak MilosKozak merged commit bfff13d into nightscout:dev Dec 7, 2021
@swissalpine
Copy link
Contributor Author

Thanks for your support (@AdrianLxM) and merging (@MilosKozak)!

@swissalpine swissalpine deleted the patch-6 branch December 8, 2021 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants