Skip to content

Conversation

@Andries-Smit
Copy link
Contributor

@Andries-Smit Andries-Smit commented Nov 30, 2021

General improvements for Wear OS:

  • Enable rotary input (Samsung watch 4 active bezel)
  • Add icons to the menu
  • Add animation to menu
  • Support back button in menu navigation
  • Add titles in action grids (bolus, tempt, etc)

@Andries-Smit Andries-Smit changed the title Wear os improvements WIP: Wear OS improvements Dec 1, 2021
@Andries-Smit Andries-Smit changed the title WIP: Wear OS improvements Wear OS improvements Dec 3, 2021
@dlvoy
Copy link
Contributor

dlvoy commented Dec 5, 2021

Hi @Andries-Smit, I am doing review & testing of your recent changes,
I've tested it on Galaxy watch 4 Classic using PL (Polish) locale which is a little bit longer
but till now were fine, and with changes to menu layout there are some slight glitches:

Screenshot are square, but displayed area is round, matching roughly circled logo in background

  1. Title of settings dialog should be centered
  2. Action dialog titles - sometimes get cut out (in Węgle letters ę and g bottom)
  3. Can you change layout of menu - to use round screen more optimally and display icon as left as possible, on round plain instead of inner square? Like on screenshot - (i) icon on Status item have lot of space on the left. Additionally - if possible - adjusting spacing and font size for item above & below main item to prevent word wrapping and getting cut out

Crown rotary input and menu scrolling works like a charm!

@Andries-Smit
Copy link
Contributor Author

@dlvoy Thanks for the feedback, I will have a look.

@dlvoy
Copy link
Contributor

dlvoy commented Dec 6, 2021

Maybe changing list to behave like: https://developer.android.com/training/wearables/overlays/lists#curved-layout will help

@Andries-Smit
Copy link
Contributor Author

Andries-Smit commented Dec 6, 2021

@dlvoy

  1. The settings were not touched in the PR, they are not beautifully, maybe next time we can have a look at an alternative implementation.
  2. Titles did get a bit more wiggle room. Tough long titles, hard to prevent from clipping, ideally it would be curved text, but that is only on SDK 31
  3. I did rewrite the outdated WearableListView into a WearableRecyclerView with the curved layout, and colour icons

image

@dlvoy
Copy link
Contributor

dlvoy commented Dec 6, 2021

Works like a charm! Thanks!
Retested on:

  • Wear OS 3 (Galaxy Watch 4 Classic) - screen 1&2
  • Wear OS 2 (Huawei Watch 2) - screen 3
  • Square Wear OS 2 Simulator - screen 4

@MilosKozak MilosKozak merged commit 9d11323 into nightscout:dev Dec 6, 2021
@MilosKozak
Copy link
Contributor

Thanks to both of you!
@Andries-Smit do you have experience with Watch development. Used libs are really obsolete :(

@Andries-Smit
Copy link
Contributor Author

@MilosKozak Just getting to know the topic. I will dive into this a bit more

@Andries-Smit Andries-Smit mentioned this pull request Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants