fix: UI toast typo (apache#13026)

* fix: UI toast typo * translate * fix error msg
nielsen-oss · Feb 14, 2021 · 1da877e · 1da877e
1 parent 0a9e94c
commit 1da877e
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 13 deletions.
diff --git a/superset-frontend/src/components/ListViewCard/ImageLoader.tsx b/superset-frontend/src/components/ListViewCard/ImageLoader.tsx
@@ -64,8 +64,8 @@ export default function ImageLoader({
             setImgSrc(imgURL);
           }
         })
-        .catch(e => {
-          logging.error(e);
+        .catch(errMsg => {
+          logging.error(errMsg);
           setImgSrc(fallback);
         });
     }

diff --git a/superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx b/superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx
@@ -302,11 +302,11 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({
         .then(() => {
           setDB(dbFetched);
         })
-        .catch(e =>
+        .catch(errMsg =>
           addDangerToast(
             t(
               'Sorry there was an error fetching database information: %s',
-              e.message,
+              errMsg.message,
             ),
           ),
         );

diff --git a/superset-frontend/src/views/CRUD/utils.tsx b/superset-frontend/src/views/CRUD/utils.tsx
@@ -144,10 +144,10 @@ export const getRecentAcitivtyObjs = (
             ];
             return res;
           })
-          .catch(e =>
+          .catch(errMsg =>
             addDangerToast(
               t('There was an error fetching your recent activity:'),
-              e,
+              errMsg,
             ),
           );
       }

diff --git a/superset-frontend/src/views/CRUD/welcome/Welcome.tsx b/superset-frontend/src/views/CRUD/welcome/Welcome.tsx
@@ -23,7 +23,11 @@ import { User } from 'src/types/bootstrapTypes';
 import { reject } from 'lodash';
 import withToasts from 'src/messageToasts/enhancers/withToasts';
 import Loading from 'src/components/Loading';
-import { getRecentAcitivtyObjs, mq } from '../utils';
+import {
+  createErrorHandler,
+  getRecentAcitivtyObjs,
+  mq,
+} from 'src/views/CRUD/utils';
 
 import ActivityTable from './ActivityTable';
 import ChartTable from './ChartTable';
@@ -111,12 +115,14 @@ function Welcome({ user, addDangerToast }: WelcomeProps) {
         setActivityData(data);
         setLoading(false);
       })
-      .catch(e => {
-        setLoading(false);
-        addDangerToast(
-          `There was an issue fetching your recent acitivity: ${e}`,
-        );
-      });
+      .catch(
+        createErrorHandler((errMsg: unknown) => {
+          setLoading(false);
+          addDangerToast(
+            t('There was an issue fetching your recent activity: %s', errMsg),
+          );
+        }),
+      );
   }, []);
 
   return (