Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update getting primary key #220

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update getting primary key #220

wants to merge 2 commits into from

Conversation

r32rf
Copy link

@r32rf r32rf commented Apr 28, 2020

No description provided.

@r32rf
chmod -x
7a5cf72 
Signed-off-by: r32rf <60923682+r32rf@users.noreply.github.com>
@r32rf
Update $this->primaryKey to $this->getKeyName()
b3e060f 
$this->primaryKey doesn't work when the primary key is controlled by
another trait.  For example when using a trait to set the primary key to
'uuid' will cause SearchableTrait to assume the primaryKey is still
'id', inherited from Model.

Since this method was only introduced in Laravel 5.4 since the
refactoring of Eloquent, this will drop support for Laravel 4.  However,
I do not see this as a great concern as Laravel 4 is unsupported and so
is anything below Laravel 5.5.

Signed-off-by: r32rf <60923682+r32rf@users.noreply.github.com>
@nicolaslopezj
Copy link
Owner

We need review on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yecademy yecademy yecademy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@r32rf @nicolaslopezj @yecademy