Added parameter context support to be able to report error location #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iMacTia
approved these changes
Dec 15, 2021
There was a problem hiding this comment.
This adds clarity to the messages and it works recursively as well 👏.
Thanks for also taking the time to update the expectations for error messages around specs 👍
@ifellinaholeonce want to have a quick look as well?
ifellinaholeonce
approved these changes
Dec 16, 2021
There was a problem hiding this comment.
This looks good to me. Thanks for adding this @crevete, this is a nice improvement 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this PR adds the parameter context support to fixes the issue #84.
@ifellinaholeonce Please review it, thanks :-)