Fix optional array behaviour #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix is an alternative to #76. It allows arrays with a default value to not raise an invalid parameter error when a value is not explicitly sent in the request. It also raises an invalid parameter error when an array parameter is explicitly sent up with a `null` value.
iMacTia
approved these changes
Sep 28, 2021
There was a problem hiding this comment.
I definitely like this solution more, and it addresses the same issue for all parameter types, not just arrays 👏
It doesn't affect any existing test which means we're not changing any expected behaviour 👍
I'd like @ifellinaholeonce to have a look as well since this is a somewhat important and semantic change
ifellinaholeonce
approved these changes
Sep 28, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fix is an alternative to #76. It allows arrays with a default value
to not raise an invalid parameter error when a value is not explicitly
sent in the request. It also raises an invalid parameter error when an
array parameter is explicitly sent up with a
nullvalue.Additional Notes
This version of the fix was inspired by the comments in #76.