Fix required parameter regression #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 1.0 release introduced a regression where parameters that were not required and had a default that isn't `#present?` would cause an invalid parameter error to be raised. This commit fixes the logic in the required validator and adds a spec so it doesn't break in the future :)
|
thanks @ClaytonPassmore great find. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The 1.0 release introduced a regression where parameters that were not
required and had a default that isn't
#present?would cause an invalidparameter error to be raised. This commit fixes the logic in the
required validator and adds a spec so it doesn't break in the future :)
Here's an example of where this regression can come into play:
If no
sortparameter is provided in the request, it defaults to{}, then the required validator ends up raising an error because{}is not present, nor is the parameter required.