Skip to content

Conversation

zentooo
Copy link
Contributor

@zentooo zentooo commented Sep 20, 2019

Description

My use case:

    # This is RESTful JSON API for updating operator resource (PATCH /operators/:operator_id)
    def update
      param! :operator_id, Integer, required: true
      param! :operator, Hash, required: true, blank: false # this 'blank: false' does not work because params[:operator] is an instance of ActionController::Parameters
      param! :update_mask, Array, required: true

      operator = Operator.find_by(id: params[:operator_id])
      # omitted
      return render json: operator
    end

@iMacTia
Copy link
Collaborator

iMacTia commented Sep 23, 2019

@zentooo it seems like we were missing support for the new Rails 5 ActionController::Parameters, and your PR is adding them correctly.
Thanks also for improving and extending the tests.
The failure in the CI is not your fault and it's something I'm investigating, so your tests should pass after that is fixed

@iMacTia iMacTia merged commit 5ecd472 into nicolasblanco:master Sep 23, 2019
@zentooo
Copy link
Contributor Author

zentooo commented Sep 24, 2019

@iMacTia
Thank you for merging PR.
Could you release a new version of gem?

@iMacTia
Copy link
Collaborator

iMacTia commented Sep 24, 2019

There are 3 issues marked as bugs that I would like to have a look at, in case there's any quick-fix.
After that I'm happy to ship a v0.11.0 👍

@iMacTia
Copy link
Collaborator

iMacTia commented Sep 24, 2019

@zentooo v0.11.0 should now be available on Rubygems 🎉

@zentooo
Copy link
Contributor Author

zentooo commented Sep 25, 2019

@iMacTia Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants