Skip to content

Replace deprecated BigDecimal.new() with BigDecimal() #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2019
Merged

Replace deprecated BigDecimal.new() with BigDecimal() #50

merged 1 commit into from
Sep 23, 2019

Conversation

davelooi
Copy link
Contributor

Description

BigDecimal deprecated .new api. The suggested upgrade is BigDecimal().

Warning message

warning: BigDecimal.new is deprecated; use BigDecimal() method instead

@iMacTia
Copy link
Collaborator

iMacTia commented Sep 23, 2019

@davelooi thanks for taking a stub at this.
The CI failure seems unrelated from your fix, so I'll have a look at that first and then hopefully your tests will pass

@iMacTia iMacTia merged commit 7abba8d into nicolasblanco:master Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davelooi @iMacTia