Added support for custom validations #23
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iMacTia
requested changes
Sep 19, 2018
There was a problem hiding this comment.
@sumocoder thanks a lot for this massive contribution 🙌!
I really appreciate you taking the time to not only add a new feature (custom validations) but also fixing the code and style.
I'd be happy to get this merged for next release if you're still willing to help.
I just need you to do the following:
- Rebase from master, hopefully this will fix the tests as well
- Have a look at my comment, it would be nice to allow passing a
Procor similar value tocustom:option
| when :max_length | ||
| raise InvalidParameterError, "Parameter cannot have length greater than #{value}" unless param.nil? || value >= param.length | ||
| when :custom | ||
| value.validate!(param) |
There was a problem hiding this comment.
If we rely on the method call instead of validate!, then options[:custom] can also be a Proc or a lambda.
Merged
|
Closing in favour of #53 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.