Improve type inference performance by simplifying child context type #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi guys, |
anba8005
added a commit
to anba8005/typed-inject
that referenced
this pull request
Mar 10, 2024
nicojs
added a commit
that referenced
this pull request
Dec 13, 2024
- Simplify error messages - Allow for near-infinite deep dependency trees. Co-authored-by: Nico Jansen <jansennico@gmail.com>
Owner
|
Thanks for your (unbelievably long) patience. I've been busy with some stuff, but back for a round of maintenance. |
|
The lack of that thing forced us to switch to InversifyJS in 2022 year :) |
yurahuchok
pushed a commit
to yurahuchok/auto-typed-inject
that referenced
this pull request
Apr 7, 2025
- Simplify error messages - Allow for near-infinite deep dependency trees. Co-authored-by: Nico Jansen <jansennico@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the TypeScript/IDE performance of long provider chains, as in this issue: #50, by explicitly simplifying the ChildContext type.
It also fixes the "Type instantiation is excessively deep and possibly infinite" issue:
Without
Simplify:With
Simplify: