Skip to content

Exploring codebase and analyzing current state #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Exploring codebase and analyzing current state #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06e5054
Initial plan
Copilot Feb 25, 2026
7fb84f9
Fix virus log values, formula display, and result condition
Copilot Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions web/src/components/form/Form.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
let ph = "";
let logInactivation = "0.5";

let formulaResult = "";
let interpolatedResult = "";
let formulaResult: number | undefined = undefined;
let interpolatedResult: number | undefined = undefined;
let error = "";

async function onSubmit(event: Event) {
Expand Down Expand Up @@ -100,20 +100,22 @@
<option value="2.5">2.5</option>
<option value="3.0">3.0</option>
{:else}
<option value="1.0">2.0</option>
<option value="2.0">3.0</option>
<option value="3.0">4.0</option>
<option value="2.0">2.0</option>
<option value="3.0">3.0</option>
<option value="4.0">4.0</option>
{/if}
</select>

<br />
<button type="submit">Submit</button>

{#if formulaResult && interpolatedResult}
{#if interpolatedResult != null}
<div class={styles.divider} />

<p class={styles.result}>Formula result:</p>
<p data-cy="result">{formulaResult}</p>
{#if formulaResult != null}
<p class={styles.result}>Formula result:</p>
<p data-cy="result">{formulaResult}</p>
{/if}

<p class={styles.result}>Interpolated result:</p>
<p data-cy="result">{interpolatedResult}</p>
Expand Down
12 changes: 5 additions & 7 deletions web/src/utils/inactivation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,13 +68,11 @@ export function getResults(validatedParams: any) {
const temperatureLow = Math.max(temperatureMin, Math.floor(t) * n);
const temperatureHigh = Number(Math.ceil(t) * n);

// Formula
const formulaResult = fcFormula(
inactivationLog,
temperature,
concentration,
ph
);
// Formula (only applicable for free chlorine + giardia)
const formulaResult =
isFreeChlorine && isGiardia
? fcFormula(inactivationLog, temperature, concentration, ph)
: undefined;

let interpolatedResult: number;
// TODO what to do about rounding?
Expand Down