Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Associated VerboseObserved progress with corresponding event #22

Merged
merged 2 commits into from
Feb 7, 2020
Merged

Associated VerboseObserved progress with corresponding event #22

merged 2 commits into from
Feb 7, 2020

Conversation

nicmcd
Copy link
Owner

@nicmcd nicmcd commented Feb 7, 2020

No description provided.

@nicmcd nicmcd linked an issue Feb 7, 2020 that may be closed by this pull request
VerboseObserver shouldn't show progress after failure when show_killed=False #21
Closed
@nicmcd nicmcd requested a review from knrafto February 7, 2020 19:46
@nicmcd
Copy link
Owner Author

nicmcd commented Feb 7, 2020

"make test" passes all checks, although admittedly VerboseObserver doesn't have unit tests.

knrafto
knrafto approved these changes Feb 7, 2020
View reviewed changes
@nicmcd nicmcd merged commit 2b7b215 into master Feb 7, 2020
@nicmcd nicmcd deleted the vob branch February 7, 2020 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knrafto knrafto knrafto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VerboseObserver shouldn't show progress after failure when show_killed=False
2 participants
@nicmcd @knrafto