Skip to content

Commit

Permalink
Replace -ginkgo.noColor with -ginkgo.no-color (gardener#5478)
Browse files Browse the repository at this point in the history
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
  • Loading branch information
ialidzhikov authored Feb 28, 2022
1 parent aad8115 commit d83f11a
Show file tree
Hide file tree
Showing 27 changed files with 30 additions and 30 deletions.
2 changes: 1 addition & 1 deletion .test-defs/CreateManagedSeed.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ spec:
args:
- >-
go test -timeout=0 -mod=vendor ./test/testmachinery/system/managed_seed_creation
--v -ginkgo.v -ginkgo.progress -ginkgo.noColor
--v -ginkgo.v -ginkgo.progress -ginkgo.no-color
-kubecfg="$TM_KUBECONFIG_PATH/gardener.config"
-managed-seed-name=$MANAGED_SEED_NAME
-shoot-name=$SHOOT_NAME
Expand Down
2 changes: 1 addition & 1 deletion .test-defs/CreateShoot.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ spec:
args:
- >-
go test -timeout=0 -mod=vendor ./test/testmachinery/system/shoot_creation
--v -ginkgo.v -ginkgo.progress -ginkgo.noColor
--v -ginkgo.v -ginkgo.progress -ginkgo.no-color
-verbose=debug
-kubecfg=$TM_KUBECONFIG_PATH/gardener.config
-seed-kubecfg-path=$TM_KUBECONFIG_PATH/seed.config
Expand Down
2 changes: 1 addition & 1 deletion .test-defs/DeleteManagedSeed.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ spec:
args:
- >-
go test -timeout=0 -mod=vendor ./test/testmachinery/system/managed_seed_deletion
--v -ginkgo.v -ginkgo.progress -ginkgo.noColor
--v -ginkgo.v -ginkgo.progress -ginkgo.no-color
-kubecfg="$TM_KUBECONFIG_PATH/gardener.config"
-managed-seed-name=$MANAGED_SEED_NAME
image: eu.gcr.io/gardener-project/3rd/golang:1.17.7
2 changes: 1 addition & 1 deletion .test-defs/DeleteShoot.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ spec:
args:
- >-
go test -timeout=0 -mod=vendor ./test/testmachinery/system/shoot_deletion
--v -ginkgo.v -ginkgo.progress -ginkgo.noColor
--v -ginkgo.v -ginkgo.progress -ginkgo.no-color
--shoot-name=$SHOOT_NAME
--project-namespace=$PROJECT_NAMESPACE
--kubecfg="$TM_KUBECONFIG_PATH/gardener.config"
Expand Down
2 changes: 1 addition & 1 deletion .test-defs/GardenletLandscaper.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ spec:
args:
- >-
go test -timeout=0 -mod=vendor ./test/testmachinery/landscaper/gardenlet
--v -ginkgo.v -ginkgo.progress -ginkgo.noColor
--v -ginkgo.v -ginkgo.progress -ginkgo.no-color
-verbose=debug
-kubecfg=$TM_KUBECONFIG_PATH/gardener.config
-seed-kubecfg-path=$TM_KUBECONFIG_PATH/seed.config
Expand Down
2 changes: 1 addition & 1 deletion .test-defs/HibernateShoot.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ spec:
args:
- >-
go test -timeout=0 -mod=vendor ./test/testmachinery/system/shoot_hibernation
--v -ginkgo.v -ginkgo.progress -ginkgo.noColor
--v -ginkgo.v -ginkgo.progress -ginkgo.no-color
--shoot-name=$SHOOT_NAME
--project-namespace=$PROJECT_NAMESPACE
--kubecfg="$TM_KUBECONFIG_PATH/gardener.config"
Expand Down
2 changes: 1 addition & 1 deletion .test-defs/MigrateShoot.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ spec:
args:
- >-
go test -timeout=0 -mod=vendor ./test/testmachinery/system/shoot_cp_migration
--v -ginkgo.v -ginkgo.progress -ginkgo.noColor
--v -ginkgo.v -ginkgo.progress -ginkgo.no-color
-target-seed-name=$SEED_NAME
-shoot-name=$SHOOT_NAME
-shoot-namespace=$PROJECT_NAMESPACE
Expand Down
2 changes: 1 addition & 1 deletion .test-defs/ReconcileShoots.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ spec:
args:
- >-
go test -timeout=0 -mod=vendor ./test/testmachinery/system/complete_reconcile
--v -ginkgo.v -ginkgo.progress -ginkgo.noColor --verbose=debug
--v -ginkgo.v -ginkgo.progress -ginkgo.no-color --verbose=debug
-kubecfg=$TM_KUBECONFIG_PATH/gardener.config
-version=$GARDENER_VERSION
Expand Down
2 changes: 1 addition & 1 deletion .test-defs/ShootKubernetesUpdateTest.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ spec:
args:
- >-
go test -timeout=0 -mod=vendor ./test/testmachinery/system/shoot_update
--v -ginkgo.v -ginkgo.progress -ginkgo.noColor -verbose=debug
--v -ginkgo.v -ginkgo.progress -ginkgo.no-color -verbose=debug
-kubecfg=$TM_KUBECONFIG_PATH/gardener.config
-shoot-name=$SHOOT_NAME
-project-namespace=$PROJECT_NAMESPACE
Expand Down
2 changes: 1 addition & 1 deletion .test-defs/TestSuiteGardenerBeta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ spec:
args:
- >-
go test -timeout=0 -mod=vendor ./test/testmachinery/suites/gardener
--v -ginkgo.v -ginkgo.progress -ginkgo.noColor
--v -ginkgo.v -ginkgo.progress -ginkgo.no-color
--report-file=$TM_EXPORT_PATH/report.json
-kubecfg=$TM_KUBECONFIG_PATH/gardener.config
-project-namespace=$PROJECT_NAMESPACE
Expand Down
2 changes: 1 addition & 1 deletion .test-defs/TestSuiteGardenerBetaSerial.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ spec:
args:
- >-
go test -timeout=0 -mod=vendor ./test/testmachinery/suites/gardener
--v -ginkgo.v -ginkgo.progress -ginkgo.noColor
--v -ginkgo.v -ginkgo.progress -ginkgo.no-color
--report-file=$TM_EXPORT_PATH/report.json
-kubecfg=$TM_KUBECONFIG_PATH/gardener.config
-project-namespace=$PROJECT_NAMESPACE
Expand Down
2 changes: 1 addition & 1 deletion .test-defs/TestSuiteGardenerDefault.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ spec:
args:
- >-
go test -timeout=0 -mod=vendor ./test/testmachinery/suites/gardener
--v -ginkgo.v -ginkgo.progress -ginkgo.noColor
--v -ginkgo.v -ginkgo.progress -ginkgo.no-color
--report-file=$TM_EXPORT_PATH/report.json
-kubecfg=$TM_KUBECONFIG_PATH/gardener.config
-project-namespace=$PROJECT_NAMESPACE
Expand Down
2 changes: 1 addition & 1 deletion .test-defs/TestSuiteGardenerDefaultSerial.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ spec:
args:
- >-
go test -timeout=0 -mod=vendor ./test/testmachinery/suites/gardener
--v -ginkgo.v -ginkgo.progress -ginkgo.noColor
--v -ginkgo.v -ginkgo.progress -ginkgo.no-color
--report-file=$TM_EXPORT_PATH/report.json
-kubecfg=$TM_KUBECONFIG_PATH/gardener.config
-project-namespace=$PROJECT_NAMESPACE
Expand Down
2 changes: 1 addition & 1 deletion .test-defs/TestSuiteGardenerRelease.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ spec:
args:
- >-
go test -timeout=0 -mod=vendor ./test/testmachinery/suites/gardener
--v -ginkgo.v -ginkgo.progress -ginkgo.noColor
--v -ginkgo.v -ginkgo.progress -ginkgo.no-color
--report-file=$TM_EXPORT_PATH/report.json
-kubecfg=$TM_KUBECONFIG_PATH/gardener.config
-project-namespace=$PROJECT_NAMESPACE
Expand Down
2 changes: 1 addition & 1 deletion .test-defs/TestSuiteGardenerReleaseSerial.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ spec:
args:
- >-
go test -timeout=0 -mod=vendor ./test/testmachinery/suites/gardener
--v -ginkgo.v -ginkgo.progress -ginkgo.noColor
--v -ginkgo.v -ginkgo.progress -ginkgo.no-color
--report-file=$TM_EXPORT_PATH/report.json
-kubecfg=$TM_KUBECONFIG_PATH/gardener.config
-project-namespace=$PROJECT_NAMESPACE
Expand Down
2 changes: 1 addition & 1 deletion .test-defs/TestSuiteShootBeta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ spec:
args:
- >-
go test -timeout=0 -mod=vendor ./test/testmachinery/suites/shoot
--v -ginkgo.v -ginkgo.progress -ginkgo.noColor
--v -ginkgo.v -ginkgo.progress -ginkgo.no-color
--report-file=$TM_EXPORT_PATH/report.json
-kubecfg=$TM_KUBECONFIG_PATH/gardener.config
-shoot-name=$SHOOT_NAME
Expand Down
2 changes: 1 addition & 1 deletion .test-defs/TestSuiteShootBetaDisruptive.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ spec:
args:
- >-
go test -timeout=0 -mod=vendor ./test/testmachinery/suites/shoot
--v -ginkgo.v -ginkgo.progress -ginkgo.noColor
--v -ginkgo.v -ginkgo.progress -ginkgo.no-color
--report-file=$TM_EXPORT_PATH/report.json
-kubecfg=$TM_KUBECONFIG_PATH/gardener.config
-shoot-name=$SHOOT_NAME
Expand Down
2 changes: 1 addition & 1 deletion .test-defs/TestSuiteShootBetaSerial.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ spec:
args:
- >-
go test -timeout=0 -mod=vendor ./test/testmachinery/suites/shoot
--v -ginkgo.v -ginkgo.progress -ginkgo.noColor
--v -ginkgo.v -ginkgo.progress -ginkgo.no-color
--report-file=$TM_EXPORT_PATH/report.json
-kubecfg=$TM_KUBECONFIG_PATH/gardener.config
-shoot-name=$SHOOT_NAME
Expand Down
2 changes: 1 addition & 1 deletion .test-defs/TestSuiteShootDefault.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ spec:
args:
- >-
go test -timeout=0 -mod=vendor ./test/testmachinery/suites/shoot
--v -ginkgo.v -ginkgo.progress -ginkgo.noColor
--v -ginkgo.v -ginkgo.progress -ginkgo.no-color
--report-file=$TM_EXPORT_PATH/report.json
-kubecfg=$TM_KUBECONFIG_PATH/gardener.config
-shoot-name=$SHOOT_NAME
Expand Down
2 changes: 1 addition & 1 deletion .test-defs/TestSuiteShootDefaultDisruptive.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ spec:
args:
- >-
go test -timeout=0 -mod=vendor ./test/testmachinery/suites/shoot
--v -ginkgo.v -ginkgo.progress -ginkgo.noColor
--v -ginkgo.v -ginkgo.progress -ginkgo.no-color
--report-file=$TM_EXPORT_PATH/report.json
-kubecfg=$TM_KUBECONFIG_PATH/gardener.config
-shoot-name=$SHOOT_NAME
Expand Down
2 changes: 1 addition & 1 deletion .test-defs/TestSuiteShootDefaultSerial.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ spec:
args:
- >-
go test -timeout=0 -mod=vendor ./test/testmachinery/suites/shoot
--v -ginkgo.v -ginkgo.progress -ginkgo.noColor
--v -ginkgo.v -ginkgo.progress -ginkgo.no-color
--report-file=$TM_EXPORT_PATH/report.json
-kubecfg=$TM_KUBECONFIG_PATH/gardener.config
-shoot-name=$SHOOT_NAME
Expand Down
2 changes: 1 addition & 1 deletion .test-defs/TestSuiteShootRelease.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ spec:
args:
- >-
go test -timeout=0 -mod=vendor ./test/testmachinery/suites/shoot
--v -ginkgo.v -ginkgo.progress -ginkgo.noColor
--v -ginkgo.v -ginkgo.progress -ginkgo.no-color
--report-file=$TM_EXPORT_PATH/report.json
-kubecfg=$TM_KUBECONFIG_PATH/gardener.config
-shoot-name=$SHOOT_NAME
Expand Down
2 changes: 1 addition & 1 deletion .test-defs/TestSuiteShootReleaseDisruptive.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ spec:
args:
- >-
go test -timeout=0 -mod=vendor ./test/testmachinery/suites/shoot
--v -ginkgo.v -ginkgo.progress -ginkgo.noColor
--v -ginkgo.v -ginkgo.progress -ginkgo.no-color
--report-file=$TM_EXPORT_PATH/report.json
-kubecfg=$TM_KUBECONFIG_PATH/gardener.config
-shoot-name=$SHOOT_NAME
Expand Down
2 changes: 1 addition & 1 deletion .test-defs/TestSuiteShootReleaseSerial.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ spec:
args:
- >-
go test -timeout=0 -mod=vendor ./test/testmachinery/suites/shoot
--v -ginkgo.v -ginkgo.progress -ginkgo.noColor
--v -ginkgo.v -ginkgo.progress -ginkgo.no-color
--report-file=$TM_EXPORT_PATH/report.json
-kubecfg=$TM_KUBECONFIG_PATH/gardener.config
-shoot-name=$SHOOT_NAME
Expand Down
2 changes: 1 addition & 1 deletion .test-defs/WakeUpShoot.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ spec:
args:
- >-
go test -timeout=0 -mod=vendor ./test/testmachinery/system/shoot_hibernation_wakeup
--v -ginkgo.v -ginkgo.progress -ginkgo.noColor
--v -ginkgo.v -ginkgo.progress -ginkgo.no-color
--shoot-name=$SHOOT_NAME
--project-namespace=$PROJECT_NAMESPACE
--kubecfg="$TM_KUBECONFIG_PATH/gardener.config"
Expand Down
8 changes: 4 additions & 4 deletions docs/development/testmachinery_tests.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ A suite can be executed by running the suite definition with ginkgo's `focus` an
to control the execution of specific labeled test. See example below:
```console
go test -timeout=0 -mod=vendor ./test/testmachinery/suites/shoot \
--v -ginkgo.v -ginkgo.progress -ginkgo.noColor \
--v -ginkgo.v -ginkgo.progress -ginkgo.no-color \
--report-file=/tmp/report.json \ # write elasticsearch formatted output to a file
--disable-dump=false \ # disables dumping of teh current state if a test fails
-kubecfg=/path/to/gardener/kubeconfig \
Expand Down Expand Up @@ -100,7 +100,7 @@ The newly created test can be tested by focusing the test with the default ginkg
and run the shoot test suite with:
```
go test -timeout=0 -mod=vendor ./test/testmachinery/suites/shoot \
--v -ginkgo.v -ginkgo.progress -ginkgo.noColor \
--v -ginkgo.v -ginkgo.progress -ginkgo.no-color \
--report-file=/tmp/report.json \ # write elasticsearch formatted output to a file
--disable-dump=false \ # disables dumping of the current state if a test fails
-kubecfg=/path/to/gardener/kubeconfig \
Expand All @@ -111,7 +111,7 @@ go test -timeout=0 -mod=vendor ./test/testmachinery/suites/shoot \
or for the gardener suite with:
```
go test -timeout=0 -mod=vendor ./test/testmachinery/suites/gardener \
--v -ginkgo.v -ginkgo.progress -ginkgo.noColor \
--v -ginkgo.v -ginkgo.progress -ginkgo.no-color \
--report-file=/tmp/report.json \ # write elasticsearch formatted output to a file
--disable-dump=false \ # disables dumping of the current state if a test fails
-kubecfg=/path/to/gardener/kubeconfig \
Expand All @@ -123,7 +123,7 @@ go test -timeout=0 -mod=vendor ./test/testmachinery/suites/gardener \
Alternatively, a test can be triggered by specifying a ginkgo focus regex with the name of the test e.g.
```
go test -timeout=0 -mod=vendor ./test/testmachinery/suites/gardener \
--v -ginkgo.v -ginkgo.progress -ginkgo.noColor \
--v -ginkgo.v -ginkgo.progress -ginkgo.no-color \
--report-file=/tmp/report.json \ # write elasticsearch formatted output to a file
-kubecfg=/path/to/gardener/kubeconfig \
-project-namespace=<gardener project namespace> \
Expand Down
2 changes: 1 addition & 1 deletion docs/proposals/09-test-framework.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ spec:
args:
- >-
go test -timeout=0 -mod=vendor ./test/integration/suite
--v -ginkgo.v -ginkgo.progress -ginkgo.noColor
--v -ginkgo.v -ginkgo.progress -ginkgo.no-color
-ginkgo.focus="[GARDENER] [BETA]"
```
Using this approach, the overall number of testsuites is then reduced to a fixed number (excluding the system steps) of `test suites * labelCombinations`.
Expand Down

0 comments on commit d83f11a

Please sign in to comment.