Skip to content

Commit

Permalink
Deprecate spec.secretRef field in Seed API (gardener#8064)
Browse files Browse the repository at this point in the history
  • Loading branch information
acumino authored Jun 13, 2023
1 parent 930db44 commit 9c07652
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 1 deletion.
6 changes: 6 additions & 0 deletions docs/api-reference/core.md
Original file line number Diff line number Diff line change
Expand Up @@ -1431,6 +1431,8 @@ Kubernetes core/v1.SecretReference
<em>(Optional)</em>
<p>SecretRef is a reference to a Secret object containing the Kubeconfig of the Kubernetes
cluster to be registered as Seed.</p>
<p>Deprecated: This field is deprecated, gardenlet must run in the Seed cluster,
hence it should use the in-cluster rest config via ServiceAccount to communicate with the Seed cluster.</p>
</td>
</tr>
<tr>
Expand Down Expand Up @@ -9569,6 +9571,8 @@ Kubernetes core/v1.SecretReference
<em>(Optional)</em>
<p>SecretRef is a reference to a Secret object containing the Kubeconfig of the Kubernetes
cluster to be registered as Seed.</p>
<p>Deprecated: This field is deprecated, gardenlet must run in the Seed cluster,
hence it should use the in-cluster rest config via ServiceAccount to communicate with the Seed cluster.</p>
</td>
</tr>
<tr>
Expand Down Expand Up @@ -9911,6 +9915,8 @@ Kubernetes core/v1.SecretReference
<em>(Optional)</em>
<p>SecretRef is a reference to a Secret object containing the Kubeconfig of the Kubernetes
cluster to be registered as Seed.</p>
<p>Deprecated: This field is deprecated, gardenlet must run in the Seed cluster,
hence it should use the in-cluster rest config via ServiceAccount to communicate with the Seed cluster.</p>
</td>
</tr>
<tr>
Expand Down
3 changes: 3 additions & 0 deletions pkg/apis/core/types_seed.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,9 @@ type SeedSpec struct {
Provider SeedProvider
// SecretRef is a reference to a Secret object containing the Kubeconfig of the Kubernetes
// cluster to be registered as Seed.
//
// Deprecated: This field is deprecated, gardenlet must run in the Seed cluster,
// hence it should use the in-cluster rest config via ServiceAccount to communicate with the Seed cluster.
SecretRef *corev1.SecretReference
// Settings contains certain settings for this seed cluster.
Settings *SeedSettings
Expand Down
3 changes: 3 additions & 0 deletions pkg/apis/core/v1beta1/generated.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions pkg/apis/core/v1beta1/types_seed.go
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,9 @@ type SeedSpec struct {
Provider SeedProvider `json:"provider" protobuf:"bytes,4,opt,name=provider"`
// SecretRef is a reference to a Secret object containing the Kubeconfig of the Kubernetes
// cluster to be registered as Seed.
//
// Deprecated: This field is deprecated, gardenlet must run in the Seed cluster,
// hence it should use the in-cluster rest config via ServiceAccount to communicate with the Seed cluster.
// +optional
SecretRef *corev1.SecretReference `json:"secretRef,omitempty" protobuf:"bytes,5,opt,name=secretRef"`
// Taints describes taints on the seed.
Expand Down
2 changes: 1 addition & 1 deletion pkg/openapi/openapi_generated.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 9c07652

Please sign in to comment.