forked from gardener/gardener
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update
kubectl wait command to handle multiple conditions correctly (…
…gardener#7439) * Fix kubectl wait command to handle multiple conditions correctly * Add bash script for checking resource conditions This script waits until all conditions are passed for a given resource in a kubernetes cluster. It takes the resource type, object name, and a list of conditions as arguments. * Enable featureGate ExpandedDNSConfig for provider local Kind cluster Apply suggestions from code review Co-authored-by: Oliver Götz <47362717+oliver-goetz@users.noreply.github.com> * Update hack/usage/wait.sh Co-authored-by: Rafael Franzke <rafael.franzke@sap.com> * Addressed review feeback * Update example/gardener-local/kind/cluster/templates/cluster.yaml Co-authored-by: Rafael Franzke <rafael.franzke@sap.com> * Fix typo * Increase retry_limit from 180 to 240 for multi-zone * `RETRY_LIMIT` has been increased to 240 (20 minutes) due to the upgrading of Gardener for seed. * In a single-zone setup, 3 istio-ingressgateway pods will be running, and it will take 9 minutes to complete the rollout. * In a multi-zone setup, 6 istio-ingressgateway pods will be running, and it will take 18 minutes to complete the rollout. * refactor: Optimize bash script and added logs messages with timesdstamp - Removed probes(rediness, liveness) for zero-downtime validator job * Addressed review feeback - Replace RETRY_LIMIT with TIMEOUT in wait-for script * use TIMEOUT instead of RETRY_LIMIT hack/ci-e2e-kind-upgrade.sh * Apply suggestions from code review Co-authored-by: Johannes Scheerer <johannes.scheerer@sap.com> --------- Co-authored-by: Oliver Götz <47362717+oliver-goetz@users.noreply.github.com> Co-authored-by: Rafael Franzke <rafael.franzke@sap.com> Co-authored-by: Johannes Scheerer <johannes.scheerer@sap.com>
- Loading branch information
4 people
authored
Feb 16, 2023
1 parent
d8da7b8
commit 9991d12
Showing
7 changed files
with
116 additions
and
110 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| #!/usr/bin/env bash | ||
| # | ||
| # Copyright (c) 2023 SAP SE or an SAP affiliate company. All rights reserved. This file is licensed under the Apache Software License, v. 2 except as noted otherwise in the LICENSE file | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| # This script waits until all conditions are passed for a given resource in a kubernetes cluster. | ||
| # It takes the resource type, object name, and a list of conditions as arguments | ||
| set -euo pipefail | ||
|
|
||
| if [ "$#" -lt 3 ]; then | ||
| echo "Usage: $0 <resource_type> <object_name> <condition_1> <condition_2> ... <condition_n> | ||
| Note: Namespace/Timeout will be used from the 'NAMESPACE'/'TIMEOUT' environment variable if set, otherwise it is optional. | ||
| TIMEOUT: The operation will be retried until the timeout[default 600 seconds] is reached, with a 5 second sleep interval between each retry. | ||
| " | ||
| exit 1 | ||
| fi | ||
|
|
||
| RESOURCE_TYPE=$1 | ||
| OBJECT_NAME=$2 | ||
| shift 2 | ||
| CONDITIONS=("$@") | ||
| NAMESPACE=${NAMESPACE:-} | ||
|
|
||
| # The number of retries before failing | ||
| TIMEOUT=${TIMEOUT:-600} | ||
|
|
||
| # The interval between each retry in seconds | ||
| SLEEP_INTERVAL=${SLEEP_INTERVAL:-5} | ||
|
|
||
| RED='\033[0;31m' | ||
| GREEN='\033[0;32m' | ||
| NO_COLOR='\033[0m' | ||
|
|
||
| echo "⏳ Checking conditions for ${RESOURCE_TYPE}/${OBJECT_NAME}..." | ||
| retries=0 | ||
| while [ "${retries}" -lt "${TIMEOUT}" ]; do | ||
| if [ -z "$NAMESPACE" ]; then | ||
| # Get the condition types in jsonpath format and pipe to yq to extract the value of conditions | ||
| CONDITION_STATES=$(kubectl get "${RESOURCE_TYPE}" "${OBJECT_NAME}" --request-timeout='1s' -o json | yq '.status.conditions') | ||
| else | ||
| # Get the condition types in jsonpath format and pipe to yq to extract the value of conditions | ||
| CONDITION_STATES=$(kubectl get "${RESOURCE_TYPE}" "${OBJECT_NAME}" -n "$NAMESPACE" --request-timeout='1s' -o json | yq '.status.conditions') | ||
| fi | ||
|
|
||
| # A flag to indicate if all conditions have passed | ||
| ALL_PASSED=true | ||
| # Iterate through each condition | ||
| for condition in "${CONDITIONS[@]}"; do | ||
| if ! echo "${CONDITION_STATES}" | yq -e '.[] | select(.type == "'"${condition}"'").status == "True"' &>/dev/null; then | ||
| ALL_PASSED=false | ||
| break | ||
| fi | ||
| done | ||
|
|
||
| # If all conditions have passed, break the loop | ||
| if [ "${ALL_PASSED}" = true ]; then | ||
| echo -e "${GREEN}✅ All conditions passed for ${RESOURCE_TYPE}/${OBJECT_NAME}.${NO_COLOR}" | ||
| break | ||
| fi | ||
|
|
||
| retries=$((retries + SLEEP_INTERVAL)) | ||
| sleep "${SLEEP_INTERVAL}" | ||
| done | ||
|
|
||
| if [ "${retries}" -ge "${TIMEOUT}" ]; then | ||
| echo -e "${RED}❌ ERROR: ${condition} not met for ${RESOURCE_TYPE}/${OBJECT_NAME} after ${TIMEOUT} seconds.${NO_COLOR}" | ||
| exit 1 | ||
| fi |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters