Skip to content

Docker image use database location in WORKDIR /data. #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2020
Merged

Docker image use database location in WORKDIR /data. #16

merged 1 commit into from
May 31, 2020

Conversation

natheihei
Copy link
Contributor

Passes --db ./data.db to entrypoint bashhub-server as defaultarguments to persist database files in docker volume /data. Otherwise, the files reside in transient /root/.config/bashhub-server/ and are not persisted after the container is removed.

Passes `--db ./data.db` to entrypoint `bashhub-server` as default
arguments to persist database files in docker volume /data.
Copy link
Owner

@nicksherron nicksherron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great pr. Thanks for contributing! 😁

@natheihei
Copy link
Contributor Author

Thanks a lot for creating the bashhub-server, super useful! Happy to help a bit! Feel free to merge the PR when you see fit.

@nicksherron nicksherron force-pushed the master branch 4 times, most recently from 8105e9e to a423ac3 Compare May 31, 2020 08:06
@nicksherron nicksherron self-requested a review May 31, 2020 08:37
@nicksherron nicksherron merged commit 0293159 into nicksherron:master May 31, 2020
@nicksherron nicksherron removed their request for review May 31, 2020 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants