Avoid rule overrides #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# sugget 1 Sugget to providing more documentation to user code `filter` rules . I am search for "why `fs.CpSync()` is not a function", until i Hover to `fs.CpSync()`, it ***need node.js v16.7.0***. # sugget 2 When I wrote `My_filter()` , the **static files also copy**, because of `filter: options.filter || filter` , `My_filter()` directly covered your rules .
...
|
Hi, I could see adding docs about the Node 16.x dependency. Node 16.x is the latest LTS btw, 14.x is considered to be in maintenance mode. I'm not sure I'm following your other change tho. Your custom filter function should completely override the built in filter function that comes from this extension. That would be the indented behavior and in most cases you wouldn't have to do this because the built in filter function is what does the md5 comparison for you before copying. Did you have something else in mind? |
|
Thank you very much for your answer, then I have no problem. Thank you |
|
No problem, I just updated the readme file in the installation section to call needing Node 16.7+ too in f3ed596. Thanks for calling that out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sugget 1
Sugget to providing more documentation to user code
filterrules .I am search for "why
fs.CpSync()is not a function", until i Hover tofs.CpSync(), it need node.js v16.7.0.sugget 2
When I wrote
My_filter(), the static files also copy, because offilter: options.filter || filter,My_filter()directly covered your rules .