Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port build system to setuptools #30

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

sbird
Copy link

@sbird sbird commented May 10, 2024

This fixes Issue #29 and allows a build with python >= 3.12

@sbird sbird changed the title Port build system to python 3.12 Port build system to setuptools May 10, 2024
@jchelly
Copy link

jchelly commented Jul 17, 2024

I've tried to use this branch to install nbodykit on python 3.12. It mostly works but I think installing the classylss module fails to copy the class data files over to the install location so computing the linear power spectrum in nbodykit (for example) fails because it can't find the data files.

I got it to work by copying these lines from master back into BuildCLib.run in setup.py:

        # copy data files from temp to classlssy package directory
        shutil.rmtree(os.path.join(self.build_lib, 'classylss', 'data'), ignore_errors=True)
        shutil.copytree(os.path.join(self.build_temp, 'data'), os.path.join(self.build_lib, 'classylss', 'data'))

But I have no idea if that's a reasonable fix.

@sbird
Copy link
Author

sbird commented Jul 20, 2024

Seems pretty reasonable to me! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants