Add parse_str, rasterize_to_raw_rgba, and optional image. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickbrowne
reviewed
Jun 18, 2018
src/lib.rs
Outdated
| @@ -189,14 +228,26 @@ impl Drop for SvgImage { | |||
| * Loads SVG data from a file at the given `Path`. | |||
| * | |||
| * # Arguments | |||
| * - `svg_path` - Path to the SVG you want to load | |||
| * - `svg_path` - Text contents of the SVG you want to load | |||
There was a problem hiding this comment.
I think these comments got switched around by accident. Shouldn't this remain as "Path to the SVG you want to load"?
Then the documentation for parse_str seems like it should be "Text contents of the SVG you want to load".
There was a problem hiding this comment.
Yep, looks like I copy-pasted at the wrong location. I'll get that updated. Thanks!
|
The changes you're proposing look good to me, I'll find them useful as well! I've just got the one question about the comments for the function arguments, then I'd be happy to merge this. |
|
All set, the comments have been updated. Thanks! |
|
Thanks, I'll try to publish a new version later today 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for creating this library! I added a few features that I needed for my application usage. Feel free to use or modify as you see fit.