Skip to content

patch: remove group that wrapped private action #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2020

Conversation

nick-invision
Copy link
Collaborator

Minor change to remove the group surrounding execution of the private action. Nested groupings are not supported so if endGroup() is called from the private action it closes the wrong group. Ideally Actions will eventually support nested groups and the ability to close groups by name, but it's not there yet.

@nick-invision nick-invision merged commit e329c80 into master Apr 23, 2020
@nick-invision nick-invision deleted the nrf/remove-log-group branch April 23, 2020 22:06
@github-actions
Copy link

🎉 This PR is included in version 3.0.10 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant