Skip to content

Documentation Version Swapping Doesn't work with Chapter Links #161

Open
@nicholas-maltbie

Description

Swapping version with a chapter selected doesn't load the new URL page properly.

Need to patch this behaviour in the main.js script.

Changing version on a page with a chapter selected should result like this:

https://nickmaltbie.com/OpenKCC/docs/manual/introduction.html#why-kinematic

to

https://nickmaltbie.com/OpenKCC/docs/v1.3.0/manual/introduction.html#why-kinematic

but instead results like this

https://nickmaltbie.com/OpenKCC/docs/manual/introduction.html#why-kinematic/../../v1.2.3/

Need to fix it to ignore the chapter tag when computing the new web link in the selectVersion function.

function selectVersion() {
selectedVersion = document.getElementById("version-selector").value
prefix = currentVersion() == "latest" ? "/../" : "/../../"
root = new URL(document.location + prefix + document.querySelector('meta[property="docfx:rel"]').content).href
rootWithVersion = new URL(document.location.href + "/../" + document.querySelector('meta[property="docfx:rel"]').content).href
leaf = window.location.href.substring(rootWithVersion.length)
versionPath = selectedVersion == "latest" ? "" : selectedVersion + "/"
window.location.href = root + versionPath + leaf
}

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingdocumentationImprovements or additions to documentationgood first issueGood for newcomers

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions