Skip to content

Commit

Permalink
Add <version> to all variant sections so that they won't be confused …
Browse files Browse the repository at this point in the history
…as actual tags

Also remove custom `onbuild` file for python since `onbuild` was removed
  • Loading branch information
yosifkit committed Sep 18, 2018
1 parent 5d2c940 commit ede38db
Show file tree
Hide file tree
Showing 7 changed files with 6 additions and 15 deletions.
2 changes: 1 addition & 1 deletion .template-helpers/variant-alpine.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
## `%%IMAGE%%:alpine`
## `%%IMAGE%%:<version>-alpine`

This image is based on the popular [Alpine Linux project](http://alpinelinux.org), available in [the `alpine` official image](https://hub.docker.com/_/alpine). Alpine Linux is much smaller than most distribution base images (~5MB), and thus leads to much slimmer images in general.

Expand Down
2 changes: 1 addition & 1 deletion .template-helpers/variant-onbuild.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
## `%%IMAGE%%:onbuild`
## `%%IMAGE%%:<version>-onbuild`

The `ONBUILD` image variants are deprecated, and their usage is discouraged. For more details, see [docker-library/official-images#2076](https://github.com/docker-library/official-images/issues/2076).

Expand Down
2 changes: 1 addition & 1 deletion .template-helpers/variant-slim.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
## `%%IMAGE%%:slim`
## `%%IMAGE%%:<version>-slim`

This image does not contain the common packages contained in the default tag and only contains the minimal packages needed to run `%%IMAGE%%`. Unless you are working in an environment where *only* the `%%IMAGE%%` image will be deployed and you have space constraints, we highly recommend using the default image of this repository.
2 changes: 1 addition & 1 deletion .template-helpers/variant-windowsservercore.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
## `%%IMAGE%%:windowsservercore`
## `%%IMAGE%%:<version>-windowsservercore`

This image is based on [Windows Server Core (`microsoft/windowsservercore`)](https://hub.docker.com/r/microsoft/windowsservercore/). As such, it only works in places which that image does, such as Windows 10 Professional/Enterprise (Anniversary Edition) or Windows Server 2016.

Expand Down
2 changes: 1 addition & 1 deletion openjdk/variant-slim.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
## `%%IMAGE%%:slim`
## `%%IMAGE%%:<version>-slim`

This image installs the `-headless` package of OpenJDK and so is missing many of the UI-related Java libraries and some common packages contained in the default tag. It only contains the minimal packages needed to run Java. Unless you are working in an environment where *only* the `%%IMAGE%%` image will be deployed and you have space constraints, we highly recommend using the default image of this repository.
9 changes: 0 additions & 9 deletions python/variant-onbuild.md

This file was deleted.

2 changes: 1 addition & 1 deletion znc/variant-slim.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
## `%%REPO%%:slim`
## `%%REPO%%:<version>-slim`

This image is smaller, but it doesn't support external modules. If you need any external C++, Perl or Python module, use `latest` instead of `slim`.

0 comments on commit ede38db

Please sign in to comment.