feat: add ite operator and boolean fringe operators to instanciate condition #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicdard
commented
Oct 18, 2022
Comment on lines
+323
to
+333
| def visit_bit_vector_ite(self, operator: BitVectorIte): | ||
| if operator in self._size: | ||
| operator.size = self._size[operator] | ||
| self._size[operator.operator_1] = operator.size | ||
| self._size[operator.operator_2] = operator.size | ||
| self._visit_ite(operator, BITVECTOR_OPERATOR) | ||
| else: | ||
| self._visit_ite(operator, BITVECTOR_OPERATOR) | ||
| operator.size = max( | ||
| [operator.operator_1.size, operator.operator_2.size]) | ||
| self._is_var[operator] = self._is_var[operator.operator_1] and self._is_var[operator.operator_2] |
There was a problem hiding this comment.
Not sure here, I am not sure whether we want to enforce that the size of both branches is the same or not, wdyt?
nicdard
force-pushed
the
feat/if-strategy
branch
from
036b103 to
06e6ca3
Compare
lweitzendorf
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.