Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor comments #1

Closed
marmarek opened this issue Jun 24, 2018 · 1 comment
Closed

Minor comments #1

marmarek opened this issue Jun 24, 2018 · 1 comment

Comments

@marmarek
Copy link

echo "$@" | qvm-run --pass-io "$VM_NAME" 'sudo bash'

Better use -u root option instead of sudo.

if ! echo "$VM_LISTING_LINE" | grep -q "Running"; then

There is qvm-check tool specifically for this purpose.

@niccokunzmann
Copy link
Owner

Thanks @marmarek I included them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants