Add ability to keep recurrence attributes on event copies #54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an argument
keep_recurrence_attributes
to theof()
function in order to manually undo the stripping ofRRULE
,RDATE
, andEXDATE
attributes from each event copy.Changes
Why?
I agree with the reason these were stripped in the first place (#24). However, for my use case, I want to keep these attributes on each event so I can differentiate between normal events and recurring events. Without these attributes, all events look the same. For example, when displaying events to the user, I want to display the recurrence rules as well.
Alternative
An alternative would be to implement grouping. I.e, return events as a dict, grouped by the recurrence, or the source event they were created from (with a special group for non-recurring events). However I felt that was overly complicated and I went for the simpler solution.