bug: Moving Event in a recurring session does not work #62

NicoHood · 2021-12-18T00:43:11Z

Create a new event on the 26th November 2021 set it to repeat every LAST Friday of the month (not the 4th)
Now go to Dezember 2021 and MOVE (Not delete) the event from the 31th to the 17th dez.
Download the resulting ICS file. The library will still tell you that the 31th is a valid date for that series

BEGIN:VCALENDAR
PRODID:-//Google Inc//Google Calendar 70.9054//EN
VERSION:2.0
CALSCALE:GREGORIAN
METHOD:PUBLISH
X-WR-CALNAME:Partyborn Zeitgeist
X-WR-TIMEZONE:Europe/Berlin
X-WR-CALDESC:Alle Events des Zeitgeist Paderborn für den Partyborn Partyala
 rm\nhttps://partyborn.de/partyalarm
BEGIN:VTIMEZONE
TZID:Europe/Berlin
X-LIC-LOCATION:Europe/Berlin
BEGIN:DAYLIGHT
TZOFFSETFROM:+0100
TZOFFSETTO:+0200
TZNAME:CEST
DTSTART:19700329T020000
RRULE:FREQ=YEARLY;BYMONTH=3;BYDAY=-1SU
END:DAYLIGHT
BEGIN:STANDARD
TZOFFSETFROM:+0200
TZOFFSETTO:+0100
TZNAME:CET
DTSTART:19701025T030000
RRULE:FREQ=YEARLY;BYMONTH=10;BYDAY=-1SU
END:STANDARD
END:VTIMEZONE
BEGIN:VEVENT
DTSTART;TZID=Europe/Berlin:20211217T213000
DTSTAMP:20211218T004508Z
UID:38m812jicsrer5gorh3mlp7qhc@google.com
RECURRENCE-ID;TZID=Europe/Berlin:20211231T213000
CREATED:20211218T004036Z
DESCRIPTION:Jeden letzten Freitag im Monat <a href="https://www.instagram.c
 om/p/CWwxmqbKXsC/">https://www.instagram.com/p/CWwxmqbKXsC/</a>
LAST-MODIFIED:20211218T004234Z
LOCATION:
SEQUENCE:3
STATUS:CONFIRMED
SUMMARY:Karaoke
TRANSP:TRANSPARENT
END:VEVENT
BEGIN:VEVENT
DTSTART;TZID=Europe/Berlin:20211126T213000
DTEND;TZID=Europe/Berlin:20211126T213000
RRULE:FREQ=MONTHLY;BYDAY=-1FR
DTSTAMP:20211218T004508Z
UID:38m812jicsrer5gorh3mlp7qhc@google.com
CREATED:20211218T004036Z
DESCRIPTION:Jeden letzten Freitag im Monat <a href="https://www.instagram.c
 om/p/CWwxmqbKXsC/">https://www.instagram.com/p/CWwxmqbKXsC/</a>
LAST-MODIFIED:20211218T004214Z
LOCATION:
SEQUENCE:2
STATUS:CONFIRMED
SUMMARY:Karaoke
TRANSP:TRANSPARENT
END:VEVENT
END:VCALENDAR

We're using [Polar.sh](https://polar.sh/niccokunzmann) so you can upvote and help fund this issue. We receive the funding once the issue is completed & confirmed by you. Thank you in advance for helping prioritize & fund our work.

NicoHood · 2021-12-18T01:54:19Z

I was able to work around the issue like this:

# Fix bug with moved recurring event:
# https://github.com/niccokunzmann/python-recurring-ical-events/issues/62
event_start = event['DTSTART'].dt
event_moved = False
for component in ical.walk():
    if component.name == "VEVENT" and component["UID"] == event["UID"]:
        recurrence_id = component.get('RECURRENCE-ID')
        if recurrence_id:
            event_moved = recurrence_id.dt == event_start
            break
if event_moved:
    logging.warning(f'Excluding moved event {event.get("SUMMARY")} because of ical library bug.')
    continue

niccokunzmann · 2021-12-21T18:59:21Z

Thanks for reporting it!

see #62

niccokunzmann · 2021-12-23T11:59:25Z

I created #65 and can reproduce the error. The ICS file looks fine, so I think the is a read bug needing further investigation. Thanks again!

Moved event not recognized - Issue #62

niccokunzmann · 2021-12-23T22:36:51Z

This fix is included in v0.2.1 upwards.

Plonq · 2023-06-29T04:18:11Z

This doesn't seem completely fixed. I have confirmed the attached ical file works, however, here's an example exported from Google Calendar that doesn't work.

There are two events (one is all-day), each with 3 occurrences, repeated weekly. The second occurrence on each event has been moved back 1 day. Here's what that looks like in Google Calendar:

Here it is correctly imported into Apple Calendar:

So to summarise, the 15th instance was moved to the 14th, and the 17th was moved to the 16th.

Processing with this lib results in 3 events on the 14th, 15th, and 22nd for the first event, and 16th, 17th, and 24th for the second event. If I had to guess, it's generating the event on the right days (14th and 16th), but instead of replacing the corresponding instances (15th and 17th) it's replacing the first instance (8th and 10th).

Here's the ical on its own:

BEGIN:VCALENDAR
PRODID:-//Google Inc//Google Calendar 70.9054//EN
VERSION:2.0
CALSCALE:GREGORIAN
METHOD:PUBLISH
X-WR-CALNAME:Test Calendar
X-WR-TIMEZONE:Australia/Sydney
BEGIN:VTIMEZONE
TZID:Australia/Sydney
X-LIC-LOCATION:Australia/Sydney
BEGIN:STANDARD
TZOFFSETFROM:+1100
TZOFFSETTO:+1000
TZNAME:AEST
DTSTART:19700405T030000
RRULE:FREQ=YEARLY;BYMONTH=4;BYDAY=1SU
END:STANDARD
BEGIN:DAYLIGHT
TZOFFSETFROM:+1000
TZOFFSETTO:+1100
TZNAME:AEDT
DTSTART:19701004T020000
RRULE:FREQ=YEARLY;BYMONTH=10;BYDAY=1SU
END:DAYLIGHT
END:VTIMEZONE
BEGIN:VEVENT
DTSTART;TZID=Australia/Sydney:20230808T140000
DTEND;TZID=Australia/Sydney:20230808T150000
RRULE:FREQ=WEEKLY;WKST=SU;UNTIL=20230828T135959Z;BYDAY=TU
DTSTAMP:20230629T040023Z
UID:7v3ju5ft4je5iq18nfdk2s3spk@google.com
CREATED:20230629T035454Z
LAST-MODIFIED:20230629T035851Z
SEQUENCE:0
STATUS:CONFIRMED
SUMMARY:Datetime
TRANSP:OPAQUE
END:VEVENT
BEGIN:VEVENT
DTSTART;TZID=Australia/Sydney:20230814T140000
DTEND;TZID=Australia/Sydney:20230814T150000
DTSTAMP:20230629T040023Z
UID:7v3ju5ft4je5iq18nfdk2s3spk@google.com
RECURRENCE-ID;TZID=Australia/Sydney:20230815T140000
CREATED:20230629T035454Z
LAST-MODIFIED:20230629T035851Z
SEQUENCE:1
STATUS:CONFIRMED
SUMMARY:Datetime
TRANSP:OPAQUE
END:VEVENT
BEGIN:VEVENT
DTSTART;VALUE=DATE:20230810
DTEND;VALUE=DATE:20230811
RRULE:FREQ=WEEKLY;WKST=SU;UNTIL=20230830;BYDAY=TH
DTSTAMP:20230629T040023Z
UID:6ep37v20d728v14rcgn17v9is6@google.com
CREATED:20230629T035522Z
LAST-MODIFIED:20230629T035854Z
SEQUENCE:0
STATUS:CONFIRMED
SUMMARY:All Day
TRANSP:TRANSPARENT
END:VEVENT
BEGIN:VEVENT
DTSTART;VALUE=DATE:20230816
DTEND;VALUE=DATE:20230817
DTSTAMP:20230629T040023Z
UID:6ep37v20d728v14rcgn17v9is6@google.com
RECURRENCE-ID;VALUE=DATE:20230817
CREATED:20230629T035522Z
LAST-MODIFIED:20230629T035854Z
SEQUENCE:1
STATUS:CONFIRMED
SUMMARY:All Day
TRANSP:TRANSPARENT
END:VEVENT
END:VCALENDAR

Here's a python script that shows the problem:

from datetime import datetime

import recurring_ical_events
from icalendar.cal import Calendar

content = """BEGIN:VCALENDAR
PRODID:-//Google Inc//Google Calendar 70.9054//EN
VERSION:2.0
CALSCALE:GREGORIAN
METHOD:PUBLISH
X-WR-CALNAME:Test Calendar
X-WR-TIMEZONE:Australia/Sydney
BEGIN:VTIMEZONE
TZID:Australia/Sydney
X-LIC-LOCATION:Australia/Sydney
BEGIN:STANDARD
TZOFFSETFROM:+1100
TZOFFSETTO:+1000
TZNAME:AEST
DTSTART:19700405T030000
RRULE:FREQ=YEARLY;BYMONTH=4;BYDAY=1SU
END:STANDARD
BEGIN:DAYLIGHT
TZOFFSETFROM:+1000
TZOFFSETTO:+1100
TZNAME:AEDT
DTSTART:19701004T020000
RRULE:FREQ=YEARLY;BYMONTH=10;BYDAY=1SU
END:DAYLIGHT
END:VTIMEZONE
BEGIN:VEVENT
DTSTART;TZID=Australia/Sydney:20230808T140000
DTEND;TZID=Australia/Sydney:20230808T150000
RRULE:FREQ=WEEKLY;WKST=SU;UNTIL=20230828T135959Z;BYDAY=TU
DTSTAMP:20230629T040023Z
UID:7v3ju5ft4je5iq18nfdk2s3spk@google.com
CREATED:20230629T035454Z
LAST-MODIFIED:20230629T035851Z
SEQUENCE:0
STATUS:CONFIRMED
SUMMARY:Datetime
TRANSP:OPAQUE
END:VEVENT
BEGIN:VEVENT
DTSTART;TZID=Australia/Sydney:20230814T140000
DTEND;TZID=Australia/Sydney:20230814T150000
DTSTAMP:20230629T040023Z
UID:7v3ju5ft4je5iq18nfdk2s3spk@google.com
RECURRENCE-ID;TZID=Australia/Sydney:20230815T140000
CREATED:20230629T035454Z
LAST-MODIFIED:20230629T035851Z
SEQUENCE:1
STATUS:CONFIRMED
SUMMARY:Datetime
TRANSP:OPAQUE
END:VEVENT
BEGIN:VEVENT
DTSTART;VALUE=DATE:20230810
DTEND;VALUE=DATE:20230811
RRULE:FREQ=WEEKLY;WKST=SU;UNTIL=20230830;BYDAY=TH
DTSTAMP:20230629T040023Z
UID:6ep37v20d728v14rcgn17v9is6@google.com
CREATED:20230629T035522Z
LAST-MODIFIED:20230629T035854Z
SEQUENCE:0
STATUS:CONFIRMED
SUMMARY:All Day
TRANSP:TRANSPARENT
END:VEVENT
BEGIN:VEVENT
DTSTART;VALUE=DATE:20230816
DTEND;VALUE=DATE:20230817
DTSTAMP:20230629T040023Z
UID:6ep37v20d728v14rcgn17v9is6@google.com
RECURRENCE-ID;VALUE=DATE:20230817
CREATED:20230629T035522Z
LAST-MODIFIED:20230629T035854Z
SEQUENCE:1
STATUS:CONFIRMED
SUMMARY:All Day
TRANSP:TRANSPARENT
END:VEVENT
END:VCALENDAR
"""

cal = Calendar.from_ical(content)
events = recurring_ical_events.of(cal).between(
    datetime(2023, 8, 1), datetime(2023, 8, 30)
)
for event in events:
    print(event["SUMMARY"], event["DTSTART"].dt)

Script output:

Datetime 2023-08-15 14:00:00+10:00
Datetime 2023-08-22 14:00:00+10:00
Datetime 2023-08-14 14:00:00+10:00
All Day 2023-08-17
All Day 2023-08-24
All Day 2023-08-16

niccokunzmann · 2023-06-29T10:33:42Z

Thanks for reporting this. I think the way you reported it, it is so clear that it can be tested and implemented.

niccokunzmann · 2023-07-05T13:34:52Z

@Plonq, could you check the PR #112? I wrote tests to reproduce the issue. Which version do you have installed?

version: 2.0.2 output:

Datetime 2023-08-08 14:00:00+10:00
Datetime 2023-08-22 14:00:00+10:00
Datetime 2023-08-14 14:00:00+10:00
All Day 2023-08-10
All Day 2023-08-24
All Day 2023-08-16

Plonq · 2023-07-05T23:05:06Z

@niccokunzmann The tests in that PR pass for me also. I am using 2.0.2 as well. I tracked down the issue to icalendar. Updating from 5.0.2 to 5.0.7 fixed it. I haven't dug into why or what changed in icalendar. If you can reproduce the issue after downgrading, then perhaps recurring-ical-events should depend on >= 5.0.7?

Sorry for the trouble, and thanks for working on this!

Plonq · 2023-07-07T03:41:18Z

Re-closing as this does appear to be fixed after all.

niccokunzmann · 2023-07-07T07:15:12Z

Hi, thanks for reporting! I wonder what to improve in the workflow so that you could have read a hint to update... Where would you expect such a hint? Would you like this to depend on the icalendar package after a certain version or would it be nicer to run the tests locally? I think, fixing versions is something I would like the upstream to do but at the same time, this creates problems in downwards compatibility. This must be solved somewhere already. I think. What do you think?

Plonq · 2023-07-09T06:45:07Z

Setting version of your dependencies is the correct way to solve this issue I think. It's not just about an upstream bug though, having a dependency without a version means someone could try using a really old version and have nothing work at all. But just in general, if lib A depends on lib B, but only works correctly with version 1.2.3 of lib B, then it should depend on >= 1.2.3 of lib B.

niccokunzmann · 2023-11-19T23:18:47Z

The versions are now set in the requirements file. This was the last condition to close this, I believe.

NicoHood added the bug Something isn't working label Dec 18, 2021

niccokunzmann added a commit that referenced this issue Dec 23, 2021

tests showing that the event is not moved

7597dd0

see #62

niccokunzmann mentioned this issue Dec 23, 2021

Moved event not recognized - Issue 62 #65

Merged

niccokunzmann mentioned this issue Dec 23, 2021

Test two events with one having an event moved #66

Closed

2 tasks

niccokunzmann closed this as completed in #65 Dec 23, 2021

niccokunzmann added a commit that referenced this issue Dec 23, 2021

Merge pull request #65 from niccokunzmann/issue-62

48fcabb

Moved event not recognized - Issue #62

basak mentioned this issue Dec 6, 2022

No API to retrieve "next" event #103

Closed

Plonq reopened this Jun 29, 2023

niccokunzmann added a commit that referenced this issue Jul 5, 2023

Add tests for #62 (comment)

fa3cb19

niccokunzmann mentioned this issue Jul 5, 2023

Add tests for #62 #112

Merged

Plonq closed this as completed Jul 7, 2023

niccokunzmann reopened this Jul 10, 2023

niccokunzmann added the polar label Aug 22, 2023

niccokunzmann closed this as completed Nov 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bug: Moving Event in a recurring session does not work #62

bug: Moving Event in a recurring session does not work #62

NicoHood commented Dec 18, 2021 •

edited by polar-sh bot

Loading

NicoHood commented Dec 18, 2021

niccokunzmann commented Dec 21, 2021

niccokunzmann commented Dec 23, 2021 •

edited

Loading

niccokunzmann commented Dec 23, 2021

Plonq commented Jun 29, 2023 •

edited

Loading

niccokunzmann commented Jun 29, 2023 via email

niccokunzmann commented Jul 5, 2023 •

edited

Loading

Plonq commented Jul 5, 2023

Plonq commented Jul 7, 2023

niccokunzmann commented Jul 7, 2023 via email

Plonq commented Jul 9, 2023

niccokunzmann commented Nov 19, 2023

bug: Moving Event in a recurring session does not work #62

bug: Moving Event in a recurring session does not work #62

Comments

NicoHood commented Dec 18, 2021 • edited by polar-sh bot Loading

NicoHood commented Dec 18, 2021

niccokunzmann commented Dec 21, 2021

niccokunzmann commented Dec 23, 2021 • edited Loading

niccokunzmann commented Dec 23, 2021

Plonq commented Jun 29, 2023 • edited Loading

niccokunzmann commented Jun 29, 2023 via email

niccokunzmann commented Jul 5, 2023 • edited Loading

Plonq commented Jul 5, 2023

Plonq commented Jul 7, 2023

niccokunzmann commented Jul 7, 2023 via email

Plonq commented Jul 9, 2023

niccokunzmann commented Nov 19, 2023

NicoHood commented Dec 18, 2021 •

edited by polar-sh bot

Loading

niccokunzmann commented Dec 23, 2021 •

edited

Loading

Plonq commented Jun 29, 2023 •

edited

Loading

niccokunzmann commented Jul 5, 2023 •

edited

Loading