make test feature used only in testing as per #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://www.reddit.com/r/rust/comments/2ysbaz/unstable_tests/cpcgs8a This should make the crate usable in stable rust
|
LGTM, restarting CI |
|
and this fails because of a problem in the encoding crate and a compiler bug... i think it should work again when this is merged and arrives in the nightly build: rust-lang/rust#25797 |
|
Restarting again because the PR should be in a nightly by now. |
|
Looks good.. One question: will this crate track nightly or stable? |
|
It's supposed to track stable. |
untitaker
added a commit
that referenced
this pull request
Jun 2, 2015
make test feature used only in testing as per
|
Thanks! |
|
I've pushed 0.0.11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.reddit.com/r/rust/comments/2ysbaz/unstable_tests/cpcgs8a
This should make the crate usable in stable rust, at least it compiles now on rust stable :)