Fix React 16 warning about javascript in href (#32)

Fixes #31
ni3galave · Apr 11, 2020 · ce4cddb · ce4cddb
1 parent 7c21f74
commit ce4cddb
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/libs/js/Editable.jsx b/libs/js/Editable.jsx
@@ -269,8 +269,7 @@ export default class Editable extends Component {
         {!(mode == 'inline' && editable) ? (
           <a
             ref={ref => (this.editableAnchor = ref)}
-            onClick={this.setEditable.bind(this, true)}
-            href="javascript:;"
+            onClick={(e) => {e.preventDefault(); this.setEditable(true)}}
           >
             {this.getValueForAnchor() || this.props.emptyValueText}
           </a>