feat(workorders): Use users class to add lookup and process workorders data #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 30, 2025 12:07
Signed-off-by: Manisha Sivakumar <manisha.sivakumar@emerson.com>
Signed-off-by: Manisha Sivakumar <manisha.sivakumar@emerson.com>
Signed-off-by: Manisha Sivakumar <manisha.sivakumar@emerson.com>
manisha-ni
requested review from
priya-ni,
ranjgith-ni and
ushakanagaraj-ni
as code owners
ranjgith-ni
approved these changes
Jun 2, 2025
| expect(result.fields).toHaveLength(1); | ||
| expect(result.fields[0].name).toEqual('Updated by'); | ||
| expect(result.fields[0].values).toEqual(['user 4', 'user 1']); | ||
| }); |
There was a problem hiding this comment.
Add a test to verify the fallback to userId
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
To add lookup for user related fields and to convert userId in workorders response to username
👩💻 Implementation
User's class to get map of user id and name to convert userId in workorders response to username🧪 Testing
✅ Checklist