adopt flake8-tidy-imports to enforce O.1.5

docs/Coding-Conventions.md

@@ -802,20 +802,23 @@ from collections import defaultdict
 from contextlib import contextmanager
 ```
 
-### [O.1.5] ✔️ **DO** Use absolute imports
+### [O.1.5] ✔️ **DO** Use absolute imports 💻
 
 > 🐍 This rule stems from [PEP 8](https://www.python.org/dev/peps/pep-0008)
 
+> 💻 This rule is enforced by error code I252
+
 ℹ️ An exception can be made for `__init__.py` files republishing child module declarations
 
 ```python
-# Bad
+# Bad - will produce I252
 from . import sibling
 from .sibling import rivalry
 ```
 
 ```python
 # Good
+import my_app.relationships.parents
 from my_app.relationships.sibling import rivalry
 ```
 
@@ -869,8 +872,8 @@ import os  # Assuming os is never used
 ```
 
 ```python
-# Good - assuming we are in a __init__.py file
-from .mysubmodule import spam, eggs  # OK even if neither are used in this module
+# Good - assuming we are in a monty/__init__.py file
+from monty.mysubmodule import spam, eggs  # OK even if neither are used in this module
 ```
 
 

ni_python_styleguide/_utils/__init__.py

@@ -1,6 +1,6 @@
-from . import code_analysis  # noqa: F401
-from . import lint  # noqa: F401
-from . import string_helpers  # noqa: F401
-from . import temp_file  # noqa: F401
+from ni_python_styleguide._utils import code_analysis  # noqa: F401
+from ni_python_styleguide._utils import lint  # noqa: F401
+from ni_python_styleguide._utils import string_helpers  # noqa: F401
+from ni_python_styleguide._utils import temp_file  # noqa: F401
 
 DEFAULT_ENCODING = "UTF-8"

ni_python_styleguide/config.ini

@@ -129,3 +129,5 @@ docstring-convention=all
 
 # flake8-import-order
 import-order-style=smarkets
+
+ban-relative-imports = True

pyproject.toml

@@ -38,6 +38,10 @@ isort = ">=5.10"
 flake8-black = ">=0.2.1"
 flake8-docstrings = ">=1.5.0"
 flake8-import-order = ">=0.18.1"
+flake8-tidy-imports = [
+    {version = ">=4.4.1", python = ">=3.7,<3.9"},
+    {version=">=4.11.0", python="^3.9"},
+]
 pep8-naming = ">=0.11.1"
 
 # Rejected flake8 plugins should be listed here (in alphabetical order)

tests/test_convention_doc/test_rules.py

@@ -53,4 +53,6 @@ def test_rule_documents_enforcement_codes(rule):
     if rule.is_automatically_enforced:
         assert rule.error_codes is not None
     else:
-        assert rule.error_codes is None
+        assert (
+            rule.error_codes is None
+        ), f"Rule ({rule.identifier}) is not marked as automatically enforced, but lists an error code {rule.error_codes}"