Pin pythonnet to 2.5.2 (or compatible) in setup.py #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When testing the built WHL file, I noticed that pythonnet 3 is still installed despite updating requirements.txt. It turns out that we need to update `install_requires` in setup.py as well.
rtzoeller
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Similar to what was done in requirements.txt, pin the version of pythonnet to 2.5.2 or compatible.
Why should this Pull Request be merged?
When testing the built WHL file, I noticed that pythonnet 3 was still installed despite updating requirements.txt. It turns out that we need to update
install_requiresin setup.py as well.What testing has been done?
Built locally (via
python setup.py bdist_wheel --universal) and installed the WHL file using pip on a clean venv. Then ranpip listto verify that pythonnet 2.5.2 was installed.