Parallel TX/RX RDMA Support #25
Conversation
Scripting tool seems to have broken due to a poorly resolved merge conflict. This commit corrects that.
Rdma plugin fixes
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
There are no changes to the following VIs. They should be reverted to what is in ni/main.
-
Transceiver/Initialize.vi -
Transceiver/Read From RDMA Buffer.vi -
Transceiver/Read Transfer Buffer.vi -
Transceiver/Read Transfer Group Buffer.vi -
Transceiver/Receive.vi -
Transceiver/Shutdown.vi -
Transceiver/Transmit.vi -
Transceiver/Write Transfer Buffer.vi -
Transceiver/Write Transfer Group Buffer.vi -
Transceiver/Write to RDMA Buffer.vi
|
Bleep bloop! LabVIEW Diff Robot here with some diffs served up hot for your pull request. Notice something funny? Help fix me on my GitHub repo. The following VIs could not be diffed:
|
|
Bleep bloop! LabVIEW Diff Robot here with some diffs served up hot for your pull request. Notice something funny? Help fix me on my GitHub repo. The following VIs could not be diffed:
|
|
The new errors file will not get installed with the RDMA build specs the way they are. See the |
|
Added the error files to the build spec. |
|
Bleep bloop! LabVIEW Diff Robot here with some diffs served up hot for your pull request. Notice something funny? Help fix me on my GitHub repo. The following VIs could not be diffed:
|
| @@ -431,8 +435,11 @@ AddOutputFilter chunkFilter | |||
| <Property Name="Destination[1].destName" Type="Str">Support Directory</Property> | |||
| <Property Name="Destination[1].path" Type="Path">/Components</Property> | |||
| <Property Name="Destination[1].path.type" Type="Str"><none></Property> | |||
| <Property Name="DestinationCount" Type="Int">2</Property> | |||
| <Property Name="Source[0].itemID" Type="Str">{143C9DB3-6F08-483B-8C9A-420653A3ACD1}</Property> | |||
| <Property Name="Destination[2].destName" Type="Str">Errors</Property> | |||
There was a problem hiding this comment.
This needs to be in the Windows project instead of the Linux project. The Post-Build Action.vi that copies the errors files to the correct location is looking for output in Windows\Components\Errors.
There was a problem hiding this comment.
Now it should be correct.
|
Bleep bloop! LabVIEW Diff Robot here with some diffs served up hot for your pull request. Notice something funny? Help fix me on my GitHub repo. The following VIs could not be diffed:
|
| <Property Name="Source[2].destinationIndex" Type="Int">0</Property> | ||
| <Property Name="Source[2].itemID" Type="Ref">/My Computer/Documents/dsf-RDMA-errors.txt</Property> | ||
| <Property Name="Source[2].sourceInclusion" Type="Str">Include</Property> | ||
| <Property Name="Source[3].destinationIndex" Type="Int">0</Property> |
There was a problem hiding this comment.
The files need to be explicitly added to the Errors directory.
There was a problem hiding this comment.
I'm just not functioning properly today. I've made the change.
|
Bleep bloop! LabVIEW Diff Robot here with some diffs served up hot for your pull request. Notice something funny? Help fix me on my GitHub repo. The following VIs could not be diffed:
|
TODO: Check the above box with an 'x' indicating you've read and followed CONTRIBUTING.md.
What does this Pull Request accomplish?
Adds parallel TX/RX session support on a single RDMA interface to the RDMA plugin.
Why should this Pull Request be merged?
RDMA interfaces should not be constrained to being either TX or RX, so this removes that limitation.
What testing has been done?