Skip to content

Page Structure + What Is A Custom Device page #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 151 commits into from
Sep 1, 2021
Merged

Conversation

cchidean
Copy link
Contributor

@cchidean cchidean commented May 26, 2021

What does this Pull Request accomplish?

Updated the index.md file and content for What_Is_A_Custom_Device.md

Why should this Pull Request be merged?

Adds new and exciting content to the custom devices handbook

What testing has been done?

Read the Docs build passed: https://niveristand-custom-device-handbook--8.org.readthedocs.build/en/8/What_Is_A_Custom_Device.html

@cchidean cchidean marked this pull request as draft May 26, 2021 12:54
Copy link
Collaborator

@PaulDanH PaulDanH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my above suggestions. Thanks for your patience. :)

@PaulDanH PaulDanH requested a review from WillCawley September 1, 2021 07:49
@WillCawley
Copy link
Contributor

Hey @phutanu and @cchidean, how close is this PR to being ready to submit? I think it would be easier for me to review the files if I could make my own PR for a tech writer review.

cchidean and others added 3 commits September 1, 2021 18:07
fixed some small typos

Co-authored-by: Paul Huțanu <62251693+phutanu@users.noreply.github.com>
@PaulDanH PaulDanH changed the title Handbook Structure + What Is A Custom Device page Sep 1, 2021
@PaulDanH PaulDanH changed the title Structure + What Is A Custom Device page Page Structures + What Is A Custom Device page Sep 1, 2021
@PaulDanH PaulDanH changed the title Page Structures + What Is A Custom Device page Page Structure + What Is A Custom Device page Sep 1, 2021
@PaulDanH PaulDanH merged commit 9683371 into ni:main Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants