Merged
Conversation
2) Adjusted init files in pcbatt_library/daq and nipcbatt folders 3) Fixed import statements to account for change in directory structure
…tructure. All tests passed. I consider this ready for merge.
…al_pattern_measurement because it was utilizing configuration.measurement_options incorrectly. It passes the unit tests now and did not previously. Changed lines are 114-117 and 122-124.
Users/john/fix callers
…ched what was anticipated
All switch development and tests complete
JRMTheSecond
requested review from
a team,
adityas-ni and
ankitan-ni
and removed request for
adityas-ni
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edited CI.yml to avoid the existing Windows architecture check and re-wrote according to the fix provided by Aditya