Add bt.TimeDelta and ht.timedelta converters#153
Merged
mjohanse-emr merged 2 commits intomainfrom Sep 4, 2025
Merged
Conversation
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Contributor
Test Results 10 files ± 0 10 suites ±0 23s ⏱️ -4s Results for commit df6558b. ± Comparison against base commit 87fe083. This pull request removes 37 and adds 42 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
mikeprosserni
requested changes
Sep 3, 2025
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
mikeprosserni
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
bintime.TimeDeltaandhightime.timedelta.PrecisionDurationPrecisionDurationto python results in ahightime.timedelta(we have to choose one)hightime.timedeltaandbintime.TimeDeltato the all-types examplePrecisionTimestampconverts tohightime.datetimebased on a recent decision to usehightimefor drivers.Why should this Pull Request be merged?
Implements part of AB#3069081
What testing has been done?
All types example, unit tests, mypy, pyright, styleguide.