Upgrade discovery.client to Poetry 2.1.4#127
Merged
mjohanse-emr merged 5 commits intomainfrom Sep 9, 2025
Merged
Conversation
added 2 commits
September 8, 2025 15:20
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Contributor
added 3 commits
September 8, 2025 15:35
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
jfriedri-ni
approved these changes
Sep 9, 2025
Collaborator
jfriedri-ni
left a comment
jfriedri-ni
left a comment
There was a problem hiding this comment.
Excited to see these changes begin 🤩
jfriedri-ni
requested changes
Sep 9, 2025
Collaborator
jfriedri-ni
left a comment
jfriedri-ni
left a comment
There was a problem hiding this comment.
I want to wait for Mike's response about Sphinx version selection.
bkeryan
approved these changes
Sep 9, 2025
jfriedri-ni
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
ni-grpc-extensionsandni.measurementlink.discovery.v1.prototo fix mypy errors and use theSERVICE_PROGRAMMING_LANGUAGEconstant from discovery.proto.annotations.Why should this Pull Request be merged?
We are moving all python projects to Poetry 2.1.4
What testing has been done?
Unit tests, mypy, pyright, styleguide.