Skip to content

Conversation

@bkeryan
Copy link
Collaborator

@bkeryan bkeryan commented Jun 5, 2025

What does this Pull Request accomplish?

Remove dependency on tomlkit.

Why should this Pull Request be merged?

I don't think we're using it. _docs_source/conf.py is using toml which is a separate package.

What testing has been done?

PR build.

@bkeryan bkeryan requested review from csjall and dixonjoel as code owners June 5, 2025 13:58
@bkeryan bkeryan enabled auto-merge (squash) June 5, 2025 14:26
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2025

Test Results

    52 files  ±0      52 suites  ±0   1h 17m 30s ⏱️ +7s
   709 tests ±0     709 ✅ ±0      0 💤 ±0  0 ❌ ±0 
21 420 runs  ±0  20 344 ✅ ±0  1 076 💤 ±0  0 ❌ ±0 

Results for commit f4ed490. ± Comparison against base commit 3443a40.

@bkeryan bkeryan merged commit 15b1bb8 into main Jun 6, 2025
17 checks passed
@dixonjoel dixonjoel deleted the users/bkeryan/remove-tomlkit branch June 6, 2025 14:31
bkeryan added a commit that referenced this pull request Jun 23, 2025
* docs: Remove tomlkit dependency

* service: Update poetry.lock

(cherry picked from commit 15b1bb8)
bkeryan added a commit that referenced this pull request Jun 24, 2025
* docs: Remove tomlkit dependency

* service: Update poetry.lock

(cherry picked from commit 15b1bb8)
bkeryan added a commit that referenced this pull request Jun 25, 2025
* docs: Upgrade Sphinx and change copyright year to "2022-%Y" (#1118)

* service: Reformat pyproject.toml

* service: Upgrade to latest Sphinx

* service: Update poetry.lock

* service: Update copyright to reflect year first published

* service: Add a comment about Sphinx version

* docs: Add gRPC and protobuf hyperlinks

* service: Update poetry.lock

(cherry picked from commit 64174c6)

* docs: Remove Sphinx --keep-going option (#1126)

(cherry picked from commit 262ab18)

* docs: Remove tomlkit dependency (#1166)

* docs: Remove tomlkit dependency

* service: Update poetry.lock

(cherry picked from commit 15b1bb8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants