Skip to content

Conversation

@Blahpapto1
Copy link
Contributor

@Blahpapto1 Blahpapto1 commented Dec 12, 2024

What does this Pull Request accomplish?

Updating SampleAllParameters.measui file for Sample Measurement and updating default value for Double2DArray in sample measurement and relevant tests. Also, disallowing the use of Double2DArray as input configuration parameter.

Why should this Pull Request be merged?

  • To update Sample Measurement Example and show Double2DArray Output control in MeasUI file.
  • To update default value of Double2DArray in sample measurement and relevant tests.
  • Disallow usage of Double2DArray as Input Configuration parameter.

What testing has been done?

  • Opened MeasUI file in MeasUI Editor and tested that the measurement changes are reflected.
    Sample

  • Opened the MeasUI file in InstrumentStudio and tested that the measurement changes are reflected.
    image

  • Adding Double2DArray as Input configuration parameter raises ValueError while running the measurement.
    valueError

@github-actions
Copy link
Contributor

github-actions bot commented Dec 12, 2024

Test Results

    40 files  ±  0      40 suites  ±0   54m 21s ⏱️ + 2m 18s
   698 tests  -   5     698 ✅  -   5      0 💤 ±0  0 ❌ ±0 
16 940 runs   - 150  15 870 ✅  - 150  1 070 💤 ±0  0 ❌ ±0 

Results for commit 180542e. ± Comparison against base commit 4c97424.

This pull request removes 5 tests.
tests.unit.test_service ‑ test___measurement_service___add_configuration__configuration_added[Double2DArray-DataType.Double2DArray-None]
tests.unit.test_service ‑ test___measurement_service___add_configuration__configuration_added[DoubleXYData-DataType.DoubleXYData-None]
tests.unit.test_service ‑ test___measurement_service___add_configuration__configuration_added[DoubleXYDataArray-DataType.DoubleXYDataArray1D-None]
tests.unit.test_service ‑ test___measurement_service___add_configuration_with_mismatch_default_value__raises_type_error[Double2DArray-DataType.Double2DArray-12]
tests.unit.test_service ‑ test___measurement_service___add_configuration_with_mismatch_default_value__raises_type_error[DoubleXYDataArray-DataType.DoubleXYDataArray1D-default_value14]

♻️ This comment has been updated with latest results.

@Blahpapto1 Blahpapto1 marked this pull request as ready for review December 12, 2024 14:54
@Blahpapto1 Blahpapto1 changed the title Update MeasUI for SampleMeasurement and update Default Value for Double2DArray in measurement and relevant tests Update MeasUI and Default Value for Double2DArray for SampleMeasurement and relevant tests. Also, block Double2DArray Input as configuration parameter. Dec 13, 2024
@Blahpapto1 Blahpapto1 changed the title Update MeasUI and Default Value for Double2DArray for SampleMeasurement and relevant tests. Also, block Double2DArray Input as configuration parameter. Update Default Value of Double2dArray in SampleMeasurement and Tests and block Input Support. Dec 17, 2024
@Blahpapto1 Blahpapto1 changed the title Update Default Value of Double2dArray in SampleMeasurement and Tests and block Input Support. Update Default Value of Double2dArray in SampleMeasurement/Tests and block Input Support. Dec 17, 2024
@Blahpapto1 Blahpapto1 changed the title Update Default Value of Double2dArray in SampleMeasurement/Tests and block Input Support. Update Default Value of Double2dArray in SampleMeasurement,Tests and block Input Support. Dec 17, 2024
@Blahpapto1 Blahpapto1 merged commit 4002977 into main Dec 18, 2024
17 checks passed
@Blahpapto1 Blahpapto1 deleted the users/avgoel/updateDouble2DArray branch December 18, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants