-
Notifications
You must be signed in to change notification settings - Fork 19
Update Default Value of Double2dArray in SampleMeasurement,Tests and block Input Support. #1034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Test Results 40 files ± 0 40 suites ±0 54m 21s ⏱️ + 2m 18s Results for commit 180542e. ± Comparison against base commit 4c97424. This pull request removes 5 tests.♻️ This comment has been updated with latest results. |
dixonjoel
approved these changes
Dec 12, 2024
dixonjoel
approved these changes
Dec 16, 2024
bkeryan
requested changes
Dec 16, 2024
packages/service/ni_measurement_plugin_sdk_service/measurement/service.py
Outdated
Show resolved
Hide resolved
bkeryan
reviewed
Dec 16, 2024
…er from measurement service tests
bkeryan
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Updating
SampleAllParameters.measuifile for Sample Measurement and updating default value for Double2DArray in sample measurement and relevant tests. Also, disallowing the use of Double2DArray as input configuration parameter.Why should this Pull Request be merged?
What testing has been done?
Opened MeasUI file in MeasUI Editor and tested that the measurement changes are reflected.

Opened the MeasUI file in InstrumentStudio and tested that the measurement changes are reflected.

Adding Double2DArray as Input configuration parameter raises

ValueErrorwhile running the measurement.