This repository has been archived by the owner on Mar 19, 2024. It is now read-only.
Delete answers.txt before building the docker image #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikemonteith
force-pushed
the
handle-secrets-more-safely
branch
from
6df7214 to
a910883
Compare
It might seem that adding "answers.txt" to the .dockerignore file would be enough to prevent answers.txt from being built into the image, however: 1. If the .dockerignore file already exists and doesn't end in a newline, answers.txt is added to the last line rather than being added as it's own line. 2. If there is no .dockerignore file, docker falls back to using the .gitignore file. This script should not be creating a one-line .dockerignore file if one doesn't already exist.
mikemonteith
force-pushed
the
handle-secrets-more-safely
branch
from
a910883 to
1597699
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It might seem that adding "answers.txt" to the .dockerignore file would be enough to
prevent answers.txt from being built into the image, however:
If the .dockerignore file already exists and doesn't end in a newline, answers.txt is
added to the last line rather than being added as it's own line.
If there is no .dockerignore file, docker falls back to using the .gitignore file. This script
should not be creating a one-line .dockerignore file if one doesn't already exist.