Merge pull request #74 from nhsuk/fix/shellcheck-fails

🔨 Check for null string
nhsuk-archive · Jun 5, 2020 · d9339f6 · d9339f6
2 parents 747d83d + 4b5b25a
commit d9339f6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/common/deploy.sh b/common/deploy.sh
@@ -10,7 +10,7 @@ check_rancher_vars() {
 
   for i in $RANCHER_ENVS; do
     VALUE=$(eval "echo \$$i")
-    if [ ! -n "$VALUE" ]; then
+    if [ -z "$VALUE" ]; then
       echo "RANCHER ENV VARIABLE $i NOT SET!"
       exit 1
     fi

diff --git a/gitlab/remove-review-app.sh b/gitlab/remove-review-app.sh
@@ -6,7 +6,7 @@ check_rancher_vars() {
 
   for i in $RANCHER_ENVS; do
     VALUE=$(eval "echo \$$i")
-    if [ ! -n "$VALUE" ]; then
+    if [ -z "$VALUE" ]; then
       echo "RANCHER ENV VARIABLE $i NOT SET!"
       exit 1
     fi