rspec failure - callback_path null pointer #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this bug only affects spec tests as real use has the environment properly configured when called via Rack |
btalbot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One spec test for #callback_path is failing due to the rack env not being available.
The setup is done in the OAuth2#authorize_params method for some reason which must be called after all options under test are configured but before any methods that expect the setup to be complete: so not easy to find a single location to always call it.
This fixes the issue when testing the callback_path configuration. I don't know why this worked in the past but something probably changed in an upstream library to expose this issue recently.